Repository navigation
pytest: check test_gossip_throttle's throttling in the log, not by a 3s floor - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_gossip_throttleasserted that each throttled session to l4 took more than 3 seconds, which fails in CI at about 2.8 to 2.95 seconds. How long a throttled session takes depends on the message sizes and on the random delay before buffered gossip is flushed (up to a second), and the 3 second figure predates the proportional throttle retry delay.The test now checks l4's log for a throttle during each slow session, and keeps a lower bound of 1 second, the minimum any throttle waits.
With the flush delay forced to its 1 ms minimum, the old test fails 12/12 (throttled sessions take 2.04 to 2.54 seconds) and the new one passes 10/10. Stock, it passes 20/20. With
dev-throttle-gossipremoved from l4 it fails, so the check still catches a missing throttle.This does not address the separate set comparison flake in the same test (#17).
Changelog-None