Repository navigation
Makefile: build the Rust plugins after msggen regenerates cln-rpc - #50
Merged
Merged
Conversation
…cies changed Changelog-None (cherry picked from commit 248b3fa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI builds intermittently fail with
error: this file contains an unclosed delimiter --> cln-rpc/src/hooks.rs. The rules for the Rust plugins don't depend on thecln-rpcsources that msggen generates, so a parallel build can start cargo, which compilescln-rpc, while msggen is still writinghooks.rs.cln-rpcandcln-pluginsources to the prerequisites of each Rust plugin and example.${CLN_RPC_SOURCES}tocln-plugin-reentrant, which that change leaves out. Its build compiles cln-plugin's dev-dependencycln-grpc, and with itcln-rpc.To reproduce, msggen was made to leave
hooks.rshalf written for 20 seconds and cargo to start 8 seconds late, thencln-rpc/src/hooks.rsand one Rust target were built withmake -j8. On the base,cln-currencyratefails with the CI error. With the backport alone,cln-currencyratebuilds andcln-plugin-reentrantfails the same way. With both commits, both build, and make starts cargo only after msggen finishes.Changelog-None