Repository navigation
bitcoin: count the witness script when weighing an anchors to_remote input - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wallet weighs a
p2wsh_from_closeinput as if its witness were only the signature, under a comment saying such outputs predate anchors. They are the opposite: the wallet only holds a P2WSH output from a close when it is an anchors channel'sto_remote, spent with the signature and the witness script (<remote_pubkey> OP_CHECKSIGVERIFY <csv> OP_CHECKSEQUENCEVERIFY, 37 bytes, or up to 39 with a lease's lock). The estimate was short by that script, so a transaction spending one at the minimum feerate fell below the relay floor and failed to broadcast.The input is now weighed with the script at its largest size. The new test spends such an output with
withdrawat 253perkw: before the change bitcoind refuses it ("min relay fee not met, 145 < 154"), after it the transaction is accepted at or above the floor.Changelog-None