Repository navigation
Use a splice's remote funding key for its in-flight commitments - #58
Merged
Merged
Conversation
kwsantiago
force-pushed
the
splice-remote-fundingkey
branch
from
October 19, 2026 23:20
d9cb182 to
410184e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A peer may give a new funding key for a splice in
splice_init/splice_ack. These changes use the splice's own key wherever an in-flight splice's funding output is involved:drop_to_chain()anddev-sign-last-txsign each in-flight commitment with that splice's remote funding key, falling back to the channel's key when the in-flight has none.hsmd_setup_channel.Tests:
test_splice_force_close_uses_splice_remote_fundingkeyforce closes with a splice pending after the peer's key changed, and checks the in-flight commitment is accepted by bitcoind;test_rbf_mutual_close_before_lockinmutually closes a dual-funded channel with an RBF candidate pending, then restarts. Both fail without the change.Changelog-None