Repository navigation
Decide splice tx_abort from the signatures actually exchanged - #61
Merged
Merged
Conversation
…plying to splice_sending_sigs
… not on our early one
…sent tx_signatures for
…_abort after upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a reconnect, a peer's
tx_abortfor a splice we initiated but never senttx_signaturesfor failed the channel: our signature on the shared input, made when the inflight is created, counted as sent. These changes decide that from what was actually sent and received, and make sure what is stored matches what the peer has.tx_signaturesonly after lightningd answers a newchanneld_splice_sending_sigs_reply, soi_sent_sigsis committed before the peer can hold our signatures.check_tx_abortrefuses a peertx_abortonce we have senttx_signatures, once we hold the peer's signatures (remote_tx_sigs, its signature on the shared input, or a finalized shared input), or, as accepter, once we have signed. Our early signature as initiator no longer counts on its own.i_sent_sigsas having sent signatures, keeping the behavior those releases had.remote_tx_sigsfalse.Tests in
tests/test_splicing.py, each failing without its change:test_splice_peer_aborts_unsigned_after_reconnect: the peer'stx_abortafter a reconnect drops the unsigned splice and the channel stays usable.test_splice_sigs_sent_after_commit: with lightningd exiting before it replies (--dev-splice-exit-before-sending-sigs), the peer never receives ourtx_signatures, as initiator or accepter, and the splice completes after restart.test_splice_tx_abort_refused_with_their_sigs: atx_abortis refused for a splice whose peer signatures we hold, and the splice is recognized when it confirms.test_splice_sent_sigs_marked_on_upgrade: an initiator inflight as older releases stored it is refused after the upgrade.Changelog-None