Repository navigation
Sign releases with a SHA256SUMS manifest - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases now carry
SHA256SUMS,SHA256SUMS.ascandprivkeyio-signing-key.asc, in the same layout as Shrike's.checksumsjob. Once every platform has uploaded, it hashes the release's installers intoSHA256SUMSand uploads it..github/scripts/verify-manifest.shrefuses a manifest that is missing any expected artifact: 2 dmg, 2 exe, 1 deb, 1 rpm and 2 AppImage. A failed matrix arm therefore cannot produce a short set to sign.SHA256SUMS.ascis a detached signature made locally with keyA47D99B6DB0D715D40C59A2023AE8A8EA7E24E38.Tested: the manifest check passes the full set and fails on a missing artifact or an unreadable file. The workflow YAML parses.