Repository navigation
Add the unified opt-in signature hash - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the unified opt-in signature hash: the digest a signature commits to when its hash type sets
SIGHASH_UNIFIED(0x20), as Bitcoin Knots defines it.SighashCache::unified_signature_hashandunified_encode_signing_data_to, taking aUnifiedSpendthat carries the data each script type commits to: the script code for bare, P2SH and segwit v0, the annex for taproot, and the leaf hash and codeseparator position for tapscript.UnifiedSighash, theUnifiedSighash-tagged hash, convertible to asecp256k1::Message.SIGHASH_ALL,SIGHASH_NONEandSIGHASH_SINGLE, with or withoutSIGHASH_ANYONECANPAY; bare, P2SH and segwit v0 commit to any byte. A hash type without the opt-in bit is refused.Purely additive: no existing API changes. Producing a signature in this form is left to the caller, since
EcdsaSighashTypecannot carry the bit.Tested against Bitcoin Knots' 166 vectors (
bitcoin/tests/data/unified_sighash.json) across all four script types, plus the refusals. The fullbitcointest suite passes, and the crate builds on its MSRV, 1.56.1.