Repository navigation
Tell a final transaction's reader how to check its replay protection - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A signed final transaction shows
Replay protection not checked, and its tooltip said to open it with the wallet that holds the keys. That cannot help: the check reads a PSBT's signatures, so the same message appears on the signing wallet too, over a transaction that is protected.The tooltip now says the check is made on the PSBT and to open the signed PSBT with that wallet, and still to treat the transaction as unprotected until then. The label and its mark are unchanged.
Checked in the GUI in both themes against a signed
ALL + Unifiedspend: the final transaction with the watch-only and with the signing wallet shows the new text, and the signed PSBT with the watch-only wallet showsReplay protected. 591 tests pass.