Fix release workflow and drop end-of-life Ruby/Rails versions - #89
Merged
Conversation
The release workflow failed at the gem push step with "Push host is missing" because the gemspec lacked allowed_push_host metadata, which fac/ruby-gem-push-action requires. - Add allowed_push_host to sift.gemspec - Switch release trigger from push to workflow_run on Tests so a release only fires after the test suite passes - Point the test workflow at main; it was still keyed to master and thus never ran on the default branch Co-authored-by: claude-code/anthropic.claude-opus-4-8 <noreply@anthropic.com> Signed-off-by: Jacob Sheehy <jacobjsheehy@gmail.com>
Ruby 2.7-3.2 and Rails 7.0/7.1 are all end-of-life. Raise the floors, trim the CI matrix to supported combinations, and bump the minor version to signal the dropped support to consumers. - required_ruby_version >= 3.3.0; activerecord >= 7.2 - CI matrix: Ruby 3.3-3.4 x Rails 7.2, 8.0 (drop dead exclude block) - Remove rails-70/rails-71 appraisals and gemfiles - TargetRubyVersion 3.3 in rubocop config; sort gemspec dev deps - Bump to 1.2.0 with CHANGELOG entry Co-authored-by: claude-code/anthropic.claude-opus-4-8 <noreply@anthropic.com> Signed-off-by: Jacob Sheehy <jacobjsheehy@gmail.com>
procore-oss requires all actions be pinned to a full SHA. Pin actions/checkout and ruby/setup-ruby to the same SHAs already used in the release workflow. Co-authored-by: claude-code/anthropic.claude-opus-4-8 <noreply@anthropic.com> Signed-off-by: Jacob Sheehy <jacobjsheehy@gmail.com>
HodaSalim
approved these changes
Jul 15, 2026
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the broken release workflow and cleans up end-of-life version support.
Release fix (
fix(release):commit)Push host is missing!— the gemspec lackedallowed_push_host, whichfac/ruby-gem-push-actionrequires. Added it.pushtoworkflow_runonTests, so a release only fires after the suite passes (matches the blueprinter pattern).main— it was still keyed tomasterand never ran on the default branch.Version cleanup (
chore:commit)required_ruby_version >= 3.3.0,activerecord >= 7.2.excludeblock.TargetRubyVersion: 3.3; sorted gemspec dev deps.Verification
Full matrix run locally — all green:
Ruby 4.0 held out of the matrix: current stable Rails isn't
ostruct-clean on 4.0 yet (LoadError: cannot load such file -- ostruct). Revisit once Rails ships an ostruct-clean release.Checklist:
🤖 Generated with Claude Code