🕵️ strengthen error propagation + add tests #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the following features: * ability to get either an `ArrayBuffer` or a `Uint8Array` response for developer ease * `ProdiaCapacityError` gives a more descriptive error asking you to check your token & job type * `ProdiaBadResponseError` shows the raw response text to give you more information e.g. "invalid token" * last item in state history is checked for failure error messages This change adds the following tests: * a bad job config must return a `ProdiaUserError` referencing that the json schema validation failed, the name of the field, and the criteria for it's failure (i.e. beyond a maximum) * a bad job type returns a `ProdiaCapacityError`. we plan on changing this in the future but the current correct response is a 429 `ProdiaCapacityError` * a bad token must return a `ProdiaBadResponseError` referencing "invalid token" * `image/png` accept type must return a real png image
calebcase
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the following features:
ArrayBufferor aUint8Arrayresponse for developer easeProdiaCapacityErrorgives a more descriptive error asking you to check your token & job typeProdiaBadResponseErrorshows the raw response text to give you more information e.g. "invalid token"This change adds the following tests:
ProdiaUserErrorreferencing that the json schema validation failed, the name of the field, and the criteria for it's failure (i.e. beyond a maximum)ProdiaCapacityError. we plan on changing this in the future but the current correct response is a 429ProdiaCapacityErrorProdiaBadResponseErrorreferencing "invalid token"image/pngaccept type must return a real png image