Volume harmonization improvement#887
Open
Sabersense-CC wants to merge 3 commits into
Open
Conversation
Harmonized button controls between 1 and 2 button volume menu control, intended for 2 button hilts in which you cannot press both buttons at the same time. Can't believe I didn't sport this one sooner - better functionality and less code! :)
Comment tweak for clarity.
Owner
|
This PR just changes a typo, the title doesn't make much sense for that... |
Contributor
Author
|
The "Comment tweak for clarity" just changes a typo, yes, but the main PR does a little bit more - it adds the one button control of: |
My numbering, which I use just for my own changelog purposes, was getting out of hand. Soz. Tweaked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harmonized button controls between 1 and 2 button volume menu control, intended for 2 button hilts in which you cannot press both buttons at the same time. Can't believe I didn't spot this one sooner - better functionality and less code! :)