fix(core): show stdout tail in exec() failure message when stderr is empty - #976
Open
Larslllllll wants to merge 1 commit into
Open
fix(core): show stdout tail in exec() failure message when stderr is empty#976Larslllllll wants to merge 1 commit into
Larslllllll wants to merge 1 commit into
Conversation
…empty
The error tail used `stderr.trim().split('\n').pop() ?? stdout…pop()`,
but pop() on the single-element array [''] returns '' — not undefined —
so the ?? fallback never fired and commands that fail while writing
their diagnostics to stdout (very common for CLIs) produced errors like:
git … failed (exit 128):
Now the last non-empty stderr line is preferred, with the last
non-empty stdout line as the actual fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
exec()'s non-zero-exit error message picks its tail with:But
''.trim().split('\n')is[''], so.pop()returns''— notundefined. The??fallback to stdout never fires.Many CLIs write their diagnostics to stdout (and nothing to stderr), so failures looked like:
— the actual diagnostic was dropped from the error the user sees.
Verified before this patch
Fix
Pick the last non-empty stderr line; fall back to the last non-empty stdout line.
Tests