fix(cli): ignore comments in payment config summary - #980
Open
WNZhao wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paymentsconfiguration summaryBug
sh1pt config paymentsparsed the first text matchingpayments: {, including examples inside//or/* */comments. A commented sample could therefore produce a fake provider summary or shadow the live configuration.Validation
pnpm exec vitest run packages/cli/src/commands/config.test.ts --reporter=dot(6/6)config-payments.tsgit diff --checkThe workspace-wide CLI typecheck currently requires generated/built internal packages and fails on missing upstream workspace module declarations; the focused file check and repository CI cover this patch.