Skip to content

fix(cli): scope skill metadata to frontmatter #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WNZhao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): scope skill metadata to frontmatter #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions packages/cli/src/commands/skills.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,33 @@ describe('skills new command', () => {
expect(stdout.join('\n')).toContain('wrote');
});

it('does not infer metadata from frontmatter-shaped text in the Markdown body', async () => {
const skillDir = join(tempDir, 'plain-skill');
mkdirSync(skillDir, { recursive: true });
const skillFile = join(skillDir, 'SKILL.md');
writeFileSync(skillFile, [
'# Plain Skill',
'',
'Example configuration:',
'',
'name: body-example',
'description: This belongs to the example, not skill metadata',
'',
].join('\n'));
const out = join(tempDir, 'plain-skill.json');
const newCmd = skillsCmd.commands.find((c) => c.name() === 'new')!;

await newCmd.parseAsync([
'--skill-file', skillFile,
'--out', out,
], { from: 'user' });

const manifest = JSON.parse(readFileSync(out, 'utf8'));
expect(manifest.name).toBe('plain-skill');
expect(manifest.title).toBe('plain-skill');
expect(manifest.description).toBe('Agent skill: plain-skill');
});

it.each(['-5', '1.9', '5abc', '1e2', '0x10', '+5', `${Number.MAX_SAFE_INTEGER + 1}`])(
'rejects invalid listing price %s before writing a manifest',
async (price) => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cli/src/commands/skills.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ export function titleFromSlug(slug: string): string {
function q(s: string): string { return JSON.stringify(s); }
async function exists(path: string): Promise<boolean> { try { await access(path); return true; } catch { return false; } }
function frontmatterValue(text: string, key: string): string | undefined {
const m = text.match(new RegExp(`^${key}:\\s*["']?([^"'\\n]+)["']?\\s*$`, 'm'));
const frontmatter = text.match(/^(?:\uFEFF)?---[ \t]*(?:\r?\n|\r)([\s\S]*?)(?:\r?\n|\r)---[ \t]*(?:(?:\r?\n|\r)|$)/)?.[1];
if (frontmatter === undefined) return undefined;
const m = frontmatter.match(new RegExp(`^${key}:\\s*["']?([^"'\\n]+)["']?\\s*$`, 'm'));
return m?.[1]?.trim();
}
async function inferFromSkill(file: string): Promise<Partial<SkillManifest>> {
Expand Down
Loading