Skip to content

fix(netlify): keep auth token out of argv - #986

Open
WNZhao wants to merge 1 commit into
profullstack:masterfrom
WNZhao:fix/netlify-token-env
Open

fix(netlify): keep auth token out of argv#986
WNZhao wants to merge 1 commit into
profullstack:masterfrom
WNZhao:fix/netlify-token-env

Conversation

@WNZhao

@WNZhao WNZhao commented Aug 24, 2026

Copy link
Copy Markdown

Summary

  • authenticate Netlify CLI through its supported NETLIFY_AUTH_TOKEN environment variable
  • stop putting the deployment token in process arguments
  • add a regression test asserting the secret is absent from argv

Netlify documents NETLIFY_AUTH_TOKEN as the CI authentication path. Keeping the token out of argv avoids exposure through process inspection and captured command errors.

Verification

  • pnpm exec vitest run packages/targets/deploy-netlify/src/index.test.ts (8/8)
  • pnpm --filter @profullstack/sh1pt-target-deploy-netlify typecheck
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant