Skip to content

fix(firebase): keep deployment token out of argv - #987

Open
WNZhao wants to merge 1 commit into
profullstack:masterfrom
WNZhao:fix/firebase-token-env
Open

fix(firebase): keep deployment token out of argv#987
WNZhao wants to merge 1 commit into
profullstack:masterfrom
WNZhao:fix/firebase-token-env

Conversation

@WNZhao

@WNZhao WNZhao commented Aug 24, 2026

Copy link
Copy Markdown

Summary

  • authenticate Firebase CLI through its supported FIREBASE_TOKEN environment variable
  • stop putting the long-lived deployment token in process arguments
  • add a regression test asserting the secret is absent from argv

Firebase documents both authentication paths and warns that these tokens are extremely sensitive long-lived credentials. Keeping the token out of argv avoids exposure through process inspection and captured command errors.

Verification

  • pnpm exec vitest run packages/targets/deploy-firebase/src/index.test.ts (8/8)
  • pnpm --filter @profullstack/sh1pt-target-deploy-firebase typecheck
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant