Conversation
Member
|
@vincentvanbush could you add tests to it (one ie. prooving, that local cache is used even if ie. redis got cleared, second prooving, that updating translation clears cache?) I wonder how we can test this in multi-threaded env Another thing - there are some conflicts now and this can not be merged. |
Contributor
Author
|
Well, with regard to testing Lit behaviour in multi-threaded environment, maybe we could try writing feature tests with Puma set as the underlying server and see if we can peek into what's been propagated to each process. I'm unsure if we will be able to have enough control over it, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a translation is available in the local hash, it's loaded from the hash; if it's not, it's loaded into the hash from Redis. Therefore arises the necessity to update the hash when it's needed.
Every time a translation is changed in any way, current timestamp is stored into Redis. In the application, a timestamp snapshot is stored and every request it is compared to the timestamp stored in Redis. If the local snapshot is older than the data in Redis, the local snapshot is updated - hash is cleared.