simple fastplotlib example#104
Open
kushalkolar wants to merge 1 commit into
Open
Conversation
Collaborator
Pull Request Test Coverage Report for Build 4507192899
💛 - Coveralls |
kushalkolar
commented
Mar 31, 2023
kushalkolar
left a comment
kushalkolar
left a comment
Contributor
Author
There was a problem hiding this comment.
@clewis7 will make a test using the nbmake plugin
| """ | ||
| Generates 512 x 512 frame and puts it in the queue for the processor | ||
| """ | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@clewis7 generate a 2D sine wave with a wavelength that depends on if the number is even or odd
Contributor
Author
There was a problem hiding this comment.
instead of doing two different wavelengths it'd be nicer to see scrolling "bars" of a sine wave, you have have n_xvals for 1 period, increase the start x_val on each new frame, and just test that the image looks correct based on the current frame number.
Contributor
Author
There was a problem hiding this comment.
@clewis7 verify that sine wave is correct based on frame index (if even or odd)
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continued from #88, rebase got messy
This works and should be ready to go!