Skip to content

WIP: Implement IPC with ZMQ#184

Closed
rwschonberg wants to merge 1 commit into
project-improv:devfrom
rwschonberg:zmq
Closed

WIP: Implement IPC with ZMQ#184
rwschonberg wants to merge 1 commit into
project-improv:devfrom
rwschonberg:zmq

Conversation

@rwschonberg

Copy link
Copy Markdown
Contributor

No description provided.

@rwschonberg rwschonberg force-pushed the zmq branch 2 times, most recently from 471ca96 to 5a8c60d Compare August 22, 2024 06:32
@coveralls

coveralls commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 12849518208

Details

  • 901 of 1121 (80.37%) changed or added relevant lines in 11 files are covered.
  • 88 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+4.5%) to 74.353%

Changes Missing Coverage Covered Lines Changed/Added Lines %
improv/config.py 81 82 98.78%
improv/utils/checks.py 5 6 83.33%
improv/harvester.py 91 93 97.85%
improv/log.py 107 114 93.86%
improv/broker.py 77 92 83.7%
improv/cli.py 18 45 40.0%
improv/actor.py 59 140 42.14%
improv/nexus.py 362 448 80.8%
Files with Coverage Reduction New Missed Lines %
improv/_version.py 1 50.0%
improv/init.py 1 50.0%
improv/cli.py 12 69.67%
improv/tui.py 13 65.98%
improv/nexus.py 17 78.58%
improv/actor.py 44 41.38%
Totals Coverage Status
Change from base Build 10689529958: 4.5%
Covered Lines: 1551
Relevant Lines: 2086

💛 - Coveralls

@jmxpearson

Copy link
Copy Markdown
Contributor

@draelos did we finish checking demos enough to merge this? I want to merge this before #199.

@draelos

draelos commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator

Noted an error in the improv-debug.log file during a minimal demo run:

asyncio Task exception was never retrieved future: <Task finished name='Task-10' coro=<Nexus.remote_input() done, defined at /home/hawkwings/Code/sandbox/improv/improv/nexus.py:539> exception=TypeError('expect a list of futures, not Task')> Traceback (most recent call last): File "/home/hawkwings/Code/sandbox/improv/improv/nexus.py", line 545, in remote_input await self.process_gui_signal([command], "TUI_Nexus") File "/home/hawkwings/Code/sandbox/improv/improv/nexus.py", line 565, in process_gui_signal done, pending = await asyncio.wait(task) File "/home/hawkwings/miniconda3/envs/improv_py310/lib/python3.10/asyncio/tasks.py", line 366, in wait raise TypeError(f"expect a list of futures, not {type(fs).__name__}") TypeError: expect a list of futures, not Task

Not sure if that is something we can handle more cleanly?

The message telling users that all actors have completed setup and the 'run' command can now be executed is missing, so I'd like to add that back.

All tests passed.

Additional investigation of how to use zmqactors in other demos beside minimal is needed. E.g. required extra args in constructors don't work automatically.

@rwschonberg

Copy link
Copy Markdown
Contributor Author

GIt hygiene - squash request to merge 82 commits into request to merge 1 commit.

@jmxpearson jmxpearson mentioned this pull request Jun 12, 2025
@jmxpearson

Copy link
Copy Markdown
Contributor

Fixed in #203.

@jmxpearson jmxpearson closed this Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants