Merged
Conversation
0xddom
force-pushed
the
dani/core-additions
branch
from
1d97e86 to
6cba679
Compare
iangneal
requested changes
Dec 3, 2025
iangneal
reviewed
Dec 4, 2025
iangneal
reviewed
Dec 4, 2025
Contributor
iangneal
left a comment
iangneal
left a comment
There was a problem hiding this comment.
Overall LGTM, I just have one quandary about the felt eq definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some types that I put into an intermediate crate and after thinking about it for a while I think makes sense to have them here.
These new types are used across the frontend in a lot of places.
A couple of them could be argued that they should be in the IR crate however, a crate the ir crate depends on uses them so they need to be lower in the
dependency tree.