Skip to content

[follow-up batch] non-blocking residuals from #61/#63 review rounds #66

Description

@project820

Non-blocking residuals from #61/#63 review rounds (post-convergence batch). None are data-destroying or crash-inducing on realistic model outputs; all surfaced by adversarial synthetic probes after the field failures were fixed.

From #61 (extraction heuristic)

  1. Document markers inside a non-HTML fence (JS template string containing a full <html>…</html>) placed BEFORE the real ```html fence can win the document branch. Fix direction: run fence segmentation before whole-input document scan, or exclude fenced spans from the document-marker scan.
  2. Perf: documentStarts per-marker callback copies/reverses marker arrays — O(markers²) on degenerate inputs with thousands of <html> mentions (bounded by 8MB cap). Fix: precompute once.

From #63 (picker/auth UX)

  1. renderAuthAffordance always appends the fixed ChatGPT "session expired / sign in again" copy even when invoked with the Grok composer key message — mixed provider messaging. Fix: provider-aware affordance copy.

Also parked earlier

  • GrokCliProvider.listModels still advertises composer (unreachable in production; latent inconsistency)
  • block-ai missing one fixture twin (transient empty inventory + visible selection)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions