Repository navigation
Conversation
…tion halt flag flag = 'webStudioDisableDistributionAndSales'. Updates Marketplace Tab states and copy for wallet connection and active sales, disables new sale creation with official-statement tooltip, and keeps end-sale flow intact.
…StudioDisableDistributionAndSales' retires
|
Visit the studio preview URL for this PR 🚀 : https://977.artist.preview.newm.io/ |
There was a problem hiding this comment.
Pull request overview
This PR updates the Studio Marketplace tab to support the wind-down period by gating sale creation UI and updating Marketplace-related copy behind the webStudioDisableDistributionAndSales feature flag, while keeping end-sale functionality available.
Changes:
- Add
webStudioDisableDistributionAndSalesflag branching to Marketplace tab views (connect wallet / create sale / active sale). - Disable/hide create-sale inputs and CTA under the flag and surface the official-statement CTA via tooltip.
- Update active-sale messaging and button styling under the flag while preserving the end-sale flow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/studio/src/pages/home/releases/MarketplaceTab/ConnectWallet.tsx | Adds flag-gated alert copy for wallet connection state. |
| apps/studio/src/pages/home/releases/MarketplaceTab/CreateSale.tsx | Gates create-sale form fields/CTA behind the flag and adds official-statement tooltip messaging. |
| apps/studio/src/pages/home/releases/MarketplaceTab/ActiveSale.tsx | Adjusts active-sale copy and button rendering/styling under the flag while keeping end-sale available. |
Comments suppressed due to low confidence (5)
apps/studio/src/pages/home/releases/MarketplaceTab/ConnectWallet.tsx:54
- In the non-flag path, the Alert copy Typography no longer sets the blue text color that was previously applied (theme.colors.blue). If the intent is to keep the existing styling when the feature flag is off, re-add the color prop (or apply the color at the Alert level) so only the flagged copy/styling changes.
<Typography fontWeight={ 500 } variant="subtitle1">
{ wallet
? "Your current wallet does not contain this track's stream " +
"tokens. To manage sales on the Marketplace, please first " +
"connect a wallet containing stream tokens for this track."
apps/studio/src/pages/home/releases/MarketplaceTab/ConnectWallet.tsx:25
- This multiline template literal includes a newline/indentation and is missing terminal punctuation, which can render with awkward spacing in the UI. Prefer a single-line string (or explicit concatenation) so the message renders consistently.
<Typography fontWeight={ 500 } variant="subtitle1">
{ wallet
? `Your current wallet does not contain this track's stream tokens.
Please connect a wallet containing stream tokens for this track`
: "Please connect a wallet containing stream tokens for this track." }
apps/studio/src/pages/home/releases/MarketplaceTab/ActiveSale.tsx:41
- Links opened with target="_blank" should include rel="noopener noreferrer" to prevent reverse-tabnabbing and avoid leaking the opener window reference.
component="a"
href={ `${NEWM_MARKETPLACE_URL}/sale/${saleId}/` }
target="_blank"
variant="secondary"
width="compact"
apps/studio/src/pages/home/releases/MarketplaceTab/ActiveSale.tsx:133
- Links opened with target="_blank" should include rel="noopener noreferrer" to prevent reverse-tabnabbing and avoid leaking the opener window reference.
component="a"
href={ `${NEWM_MARKETPLACE_URL}/sale/${saleId}/` }
target="_blank"
width="compact"
>
apps/studio/src/pages/home/releases/MarketplaceTab/ActiveSale.tsx:124
- Since this component returns null when
saleis falsy andSale.idis required, passingsaleId ?? ""can mask unexpected states and can produce an invalid Marketplace URL (/sale//). Prefer deriving saleId after the null check (or passsale.iddirectly) and avoid the empty-string fallback.
<SundownButtons
isEndSaleLoading={ isEndSaleLoading }
saleId={ saleId ?? "" }
setIsEndSaleModalOpen={ setIsEndSaleModalOpen }
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmkirshon
left a comment
There was a problem hiding this comment.
Looks good, made a comment on the Jira ticket for some potential additional copy changes in this flow.
Pull Request — Issue STUD-578
Overview
Files Summary
Modified (3)
apps/studio/src/pages/home/releases/MarketplaceTab/ConnectWallet.tsxapps/studio/src/pages/home/releases/MarketplaceTab/CreateSale.tsxofficial-statement messaging.
apps/studio/src/pages/home/releases/MarketplaceTab/ActiveSale.tsxImpact
states under the flag.
Testing
Related Issues
Dependencies
Demo
Figma order
Additional Notes
--END--