Repository navigation
[STUD-581][Enhancement]: Implement final Marketplace Tab 'End Sale' copy edits - #979
Conversation
…stributionAndSales' flag Unify End Sale dialog messaging when sales are disabled. Keep sold-out vs active copy for default behavior.
|
Visit the studio preview URL for this PR 🚀 : https://979.artist.preview.newm.io/ |
dmkirshon
left a comment
dmkirshon
left a comment
There was a problem hiding this comment.
Looks good, there is a small copy update before merging.
| { webStudioDisableDistributionAndSales ? ( | ||
| <> | ||
| The sale will be removed from the Marketplace. All earnings | ||
| and and any unsold stream tokens will be moved to your wallet. |
There was a problem hiding this comment.
Extra and in this copy, recommend to fix and update ticket.
| <Typography variant="subtitle1"> | ||
| Your stream token sale is being removed from the Marketplace! | ||
| </Typography> |
There was a problem hiding this comment.
One more minor style issue identified. This text is not centered in the Alert, but mainly I think it's because it is wrapped with the typography wrapper. This is also causing it not to show up in the Alert Title font.
I think we should keep it as an Alert Title, but let me know if there was a reason it was wrapped this way and not just added outside of the AlertTitle?
There was a problem hiding this comment.
Good catch @dmkirshon, I'll update the conditional rendering.
2 participants
Pull Request — Issue STUD-581
Overview
Files Summary
Modified (3)
newm-web/apps/studio/src/pages/home/releases/MarketplaceTab/EndSaleModal.tsxnewm-web/apps/studio/src/pages/home/releases/MarketplaceTab/SaleEndPending.tsxnewm-web/apps/studio/src/pages/home/releases/MarketplaceTab/ActiveSale.tsxImpact
webStudioDisableDistributionAndSalesis enabled.Testing
Related Issues
Dependencies
Demo
Additional Notes
--END--