-
Notifications
You must be signed in to change notification settings - Fork 70
Conversation
|
|
|
This looks awesome. The only thing I'm concerned about is it limits people outside of the project from being included in the nulecule-library and Would the epic/end-goal be our own hub (hub.projectatomic.io) similar to Docker's with a hub of atomicapp's people can download, test, etcetera? Of course we'd add a query / regex that Nulecule needs to be included in the upload, etcetera. Or is the goal of this to provide a good set of examples for user's to use, etc? What about a |
|
@charliedrage How does that limit people from being included in nulecule-library? It's just about sending a PR:-) I've also proposed an "external entries" for index in projectatomic/nulecule-library#17 I don't know about Search would be definitely valuable part of index implementation in Atomic App (this proposal already mentions The initial goal is to make it easy for developers to find well managed Atomic Apps which they can use or incorporate in their own apps. |
|
@vpavlin Otherwise, really good work! I like it 👍 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe should keep gitpython within requirements.txt in order to keep this consistent across all Dockerfile's.
gitpython==1.0.1 and prevent compatibility issues (Debian may have a different package) as seen with our previous lockfile issue.
|
just to be clear let's leave this on the burner until beta3 has passed (and maybe even GA) |
|
@cdrage's comment about a registry made me wonder. If we could get a label based search on docker registry then we could just leverage that (or any private registries). That seems more extensible, although it would require a big patch upstream. However I see label searches providing even more value down the road outside of this function. |
|
@bexelbie This idea is not new:) Me and @shaded-enmity had that one a long time ago (basically when we started to use labels like Anyway, I talked to Distribution (v2 registry) maints last week at DockerCon and they said there is no plan for this yet. I am pretty sure there is/was some issue for that, I'll try to find it (or if @shaded-enmity knows about any?). I also talked to quay.io devs and they said this feature should land in their registry in a couple of months:) Anyway, yes, this would be the best solution for "index" Also we shouldn't forget about the moratorium for Remote API which might influence addition of this feature https://github.com/docker/docker/blob/master/ROADMAP.md#23-remote-registry-operations |
|
@vpavlin The original issue can be found here: distribution/#600, the later discussion happened via emails so let me search the archives. The proof of concept code works by scanning the Distribution/Registry file system storage for a magic header found in all manifests. Labels and some additional bits of information are then collated on a per-repo basis and signed with distribution key. There's also an
Then you also need to install the mkdir metadata/ keys/
python crypto_setup.py -g keys/ md-key.json
python service.py -g md-key.json /opt/data/cache metadata/I should probably include these in the provisioning script and update it to use a better base image like this one if this gets any attention :) |
|
Hey @vpavlin So i've been working on refactoring this and making it viable for a merge into Atomic App :) One question, in regards to the |
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Yeah, I was trying to find the usage of fetch, but with no luck:D I guess I just lost the idea in the middle of coding:-) But yes, generally, if you try to list, you might either get it pull automatically, or be informed there is not index locally and if you want to pull it. I didn't follow development lately, so I have not idea what fits better to overall UX of AtomicApp now. Location sounds ok |
|
@vpavlin thanks man :) Yeah, I was looking at how cccp-index does it, if we can keep an index.yml within nulecule-library that would be great (or like what you and dusty said, keep it in a container and rely on docker hub for hosting, which may be better). I'll refactor some of this code and ping you :) |
@kbsingh's idea of index and cccp was always very interesting for me. This PR adds new subcommand
indexwhich has then 3 verbs:It operates on top of https://github.com/projectatomic/nulecule-library where I have sent another pull request which is needed for this to work properly - projectatomic/nulecule-library#17
Workflow
nulecule-librarygenerategen_index.yaml(this is just a POC and WIP;) )nulecule-libraryto build an image containing index.yaml which is pulled and unpacked byindex listandindex infoif the index file is missing locally - works already as I set up the Automated Build for my other PR branch (image:nulecule/index)gen_index.yamland list all available apps/componentsI haven't tried to map it to
atomiccommand anyhow yet..:(Reasoning
This
indexfunctionality can later be used by other tools to query available component and information about them (searching, filtering, automated addition of components...). It will also help developers to find components for their apps easily using Atomic App directly.I'd also like to see filtering being added for the
listverb to make it easy to search for f.e.--filter=specversion=0.02)--filter=provider=docker)--filter=id=mysql*)Comments are very welcome:-)