This repository was archived by the owner on Mar 22, 2018. It is now read-only.
Add a Dockerfile with the nulecule-library index #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a Dockerfile as well as an index.yaml for the generation of a `atomicapp index list` compatible atomicapp library image. Documentation has also been included on how to generate the actual image as well.
Member
Author
|
This replaces #17 |
Contributor
|
Have a look at how I implemented 'index list' in grasshopper there may be smarter way than providing a static file ;) |
Member
Author
Member
Author
|
@goern @rtnpro @dustymabe @vpavlin Could you guys LGTM / review this for merging? :) |
5 tasks
Contributor
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a Dockerfile as well as an index.yaml for the
generation of a
atomicapp index listcompatible atomicapp libraryimage.
Documentation has also been included on how to generate the actual
image as well.
Btw @vpavlin, I decided to use scratch as it would be the smallest possible Docker image for the index. I liked your method, but thought this would be better rather than the 290mb+ Atomic App image.