Conversation
| const existingLinks = this._gLinks.selectAll('.link') | ||
|
|
||
| existingLinks | ||
| // NOTE: Key-function provides D3 with information about which datum maps to which |
There was a problem hiding this comment.
You need to put this comment back in
src/components/graph/graph.ts
Outdated
| switch (this._linkMode) { | ||
| case LinkType.STRAIGHT: | ||
| existingLinks | ||
| // NOTE: Key-function provides D3 with information about which datum maps to which |
There was a problem hiding this comment.
This comment is meaningless there.
| .attr('stroke-width', GraphComponent._LINK_STROKE) | ||
| .attr('fill', 'none') | ||
| .on('contextmenu', (l: ILinkTuple) => this._onLinkContextMenu(l)) | ||
| .data(this._graphData!.linkData, (l: ILinkTuple) => l.id) |
There was a problem hiding this comment.
Can you move this up, it would make more sense a few lines above rather than at the very bottom. And the comment about the 'Key-function' is referring to this line, so move that comment to be next to this as well.
…DataChain/morbo into feature/curved-links-v2
|
@miktime148 Out of curiosity, what is the status of this PR? Are we moving forward with this or is this just put on the back burner? |
|
@KelvinKKLin This PR is pretty much finished, we just decided not to commit it to master because at the time we were dealing with other issues. I can ask @francium if i should fix the conflicts and commit it, however its not a big deal if we dont because it only adds curved links. |
3 participants
You can now specify whether you want straight links, links with vertical tangents or links with horizontal tangents