QueryResult: use stdlib for envelope decoding - #2110
Merged
Conversation
liggitt
force-pushed
the
query-result
branch
from
September 8, 2026 20:29
90a7540 to
b7d31f2
Compare
kakkoyun
approved these changes
Sep 9, 2026
Signed-off-by: Jordan Liggitt <liggitt@google.com>
│ 1-query-main.txt │ 2-query-envelope.txt │
│ sec/op │ sec/op vs base │
QueryResult/scalar-14 473.4n ± 4% 731.7n ± 2% +54.58% (p=0.002 n=6)
QueryResult/vector-14 74.66µ ± 9% 86.01µ ± 1% +15.20% (p=0.002 n=6)
QueryResult/matrix-float-14 19.59µ ± 7% 26.84µ ± 2% +37.02% (p=0.002 n=6)
QueryResult/matrix-histogram-14 168.8µ ± 3% 268.5µ ± 1% +59.11% (p=0.002 n=6)
geomean 18.49µ 25.95µ +40.37%
│ 1-query-main.txt │ 2-query-envelope.txt │
│ B/op │ B/op vs base │
QueryResult/scalar-14 544.0 ± 0% 704.0 ± 0% +29.41% (p=0.002 n=6)
QueryResult/vector-14 38.04Ki ± 0% 37.88Ki ± 0% -0.43% (p=0.002 n=6)
QueryResult/matrix-float-14 21.33Ki ± 0% 21.24Ki ± 0% -0.41% (p=0.002 n=6)
QueryResult/matrix-histogram-14 133.2Ki ± 0% 131.5Ki ± 0% -1.23% (p=0.002 n=6)
geomean 15.48Ki 16.42Ki +6.11%
│ 1-query-main.txt │ 2-query-envelope.txt │
│ allocs/op │ allocs/op vs base │
QueryResult/scalar-14 16.00 ± 0% 17.00 ± 0% +6.25% (p=0.002 n=6)
QueryResult/vector-14 747.0 ± 0% 689.0 ± 0% -7.76% (p=0.002 n=6)
QueryResult/matrix-float-14 497.0 ± 0% 459.0 ± 0% -7.65% (p=0.002 n=6)
QueryResult/matrix-histogram-14 4.567k ± 0% 4.229k ± 0% -7.40% (p=0.002 n=6)
geomean 405.8 388.3 -4.32%
Signed-off-by: Jordan Liggitt <liggitt@google.com>
liggitt
force-pushed
the
query-result
branch
from
September 10, 2026 13:22
b7d31f2 to
09eacad
Compare
Contributor
Author
|
rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @bwplotka
part of #2105
Benchmark results of switching the envelope decode to stdlib:
For scalar query results (tiny)
For vector and matrix query results (large)