model: add Duration unit constants and conversion methods - #952
Merged
Conversation
Working with model.Duration is awkward for simple conversions and multiplications because callers must cast to/from time.Duration: int64(d)/int64(time.Millisecond) 15 * 24 * model.Duration(time.Hour) model.Duration(n * time.Millisecond) Add common unit constants (Nanosecond through Week) and conversion methods (Nanoseconds through Hours) mirroring the standard time package. Day and Week are included because ParseDuration already supports those units. Fixes prometheus#222 Signed-off-by: Dean Chen <862469039@qq.com>
…ants Signed-off-by: Dean Chen <862469039@qq.com>
bwplotka
approved these changes
Aug 24, 2026
| Minute = 60 * Second | ||
| Hour = 60 * Minute | ||
| Day = 24 * Hour | ||
| Week = 7 * Day |
Member
There was a problem hiding this comment.
Technically we also define a year, should we add it?
Contributor
Author
There was a problem hiding this comment.
skipped it. ParseDuration already takes y, and a calendar year isn't a fixed duration like day/week.
Member
There was a problem hiding this comment.
I know, but we treat it as fixed in some calculations, anyway let's skip to not surface confusion
Drop the extra time.Duration wrappers. Prometheus timestamps are milliseconds; Day/Week constants stay because ParseDuration supports those units. Signed-off-by: Dean Chen <862469039@qq.com>
bwplotka
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend
model.Durationwith unit constants and conversion methods so callers no longer need awkward casts to/fromtime.Duration.Constants (mirroring
timepackage, plus Day/Week whichParseDurationalready supports):model.Nanosecond,model.Microsecond,model.Millisecondmodel.Second,model.Minute,model.Hourmodel.Day,model.WeekMethods (same signatures as
time.Duration):Nanoseconds(),Microseconds(),Milliseconds()→int64Seconds(),Minutes(),Hours()→float64Before / after
Fixes #222
cc @roidelapluie @gotjosh
Test plan
go test ./model/ -run 'TestDuration' -count=1time.*equivalents, multiply usage, conversion methods (including negative durations)