Skip to content

bcachefs collector#3523

Merged
SuperQ merged 1 commit intoprometheus:masterfrom
ananthb:bcachefs-collector
Mar 13, 2026
Merged

bcachefs collector#3523
SuperQ merged 1 commit intoprometheus:masterfrom
ananthb:bcachefs-collector

Conversation

@ananthb
Copy link
Contributor

@ananthb ananthb commented Jan 25, 2026

Add support for collecting and reporting metrics from bcachefs filesystems.

@ananthb ananthb force-pushed the bcachefs-collector branch 5 times, most recently from b1d2f00 to bd5c99d Compare January 26, 2026 04:57
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the raw file parsing to https://github.com/prometheus/procfs/tree/master/bcache.

@ananthb
Copy link
Contributor Author

ananthb commented Feb 24, 2026

I've re-worked the code with the changes from procfs master and they look good. If you want to cut a new release of procfs I can use it here.

@SuperQ
Copy link
Member

SuperQ commented Feb 24, 2026

I will try and cut a procfs release in the next day or so.

@ananthb ananthb force-pushed the bcachefs-collector branch 2 times, most recently from 98c4669 to fe8cbbd Compare February 27, 2026 13:07
@ananthb ananthb requested a review from SuperQ February 27, 2026 13:07
@ananthb
Copy link
Contributor Author

ananthb commented Feb 28, 2026

@SuperQ my testdata was out of date in https://github.com/prometheus/procfs so the code wasn't working with current bcachefs. I've fixed it here and tested it.

@ananthb ananthb force-pushed the bcachefs-collector branch 3 times, most recently from d5e6a5e to 9c9377d Compare February 28, 2026 15:42
@ananthb ananthb force-pushed the bcachefs-collector branch 2 times, most recently from 03b2a63 to 736a1cd Compare March 1, 2026 11:05
@ananthb ananthb requested a review from SuperQ March 1, 2026 11:07
@ananthb ananthb force-pushed the bcachefs-collector branch 4 times, most recently from e87dd71 to f514311 Compare March 1, 2026 11:45
@ananthb ananthb force-pushed the bcachefs-collector branch from f514311 to 824eae0 Compare March 12, 2026 10:20
@ananthb ananthb requested a review from SuperQ March 12, 2026 10:21
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit.

@ananthb ananthb force-pushed the bcachefs-collector branch from 824eae0 to 8639975 Compare March 12, 2026 11:44
@ananthb ananthb requested a review from SuperQ March 12, 2026 11:45
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixs, otherwise LGTM.

Add support for collecting and reporting metrics from bcachefs
filesystems.

Signed-off-by: Ananth Bhaskararaman <antsub@gmail.com>
@ananthb ananthb force-pushed the bcachefs-collector branch from ce504e1 to 579718a Compare March 12, 2026 18:03
@ananthb
Copy link
Contributor Author

ananthb commented Mar 12, 2026

Done

@SuperQ SuperQ merged commit 1a4cac6 into prometheus:master Mar 13, 2026
13 checks passed
@ananthb ananthb deleted the bcachefs-collector branch March 14, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants