Skip to content

fix: handle 'delayed' state in sync_completed parsing #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mehrdadbn9 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: handle 'delayed' state in sync_completed parsing #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed84a3
fix: handle 'delayed' state in sync_completed parsing
mehrdadbn9 Feb 24, 2026
427ead0
Add comprehensive tests for delayed sync_completed parsing
mehrdadbn9 Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sysfs/mdraid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func (fs FS) Mdraids() ([]Mdraid, error) {
}

if val, err := util.SysReadFile(filepath.Join(path, "sync_completed")); err == nil {
if val != "none" {
if val != "none" && val != "delayed" {
var a, b uint64

// File contains two values representing the fraction of number of completed
Expand Down
23 changes: 23 additions & 0 deletions sysfs/mdraid_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,26 @@ func TestMdraidStats(t *testing.T) {
t.Fatalf("unexpected Mdraid (-want +got):\n%s", diff)
}
}
func TestMdraidDelayedSyncCompleted(t *testing.T) {
fs, err := NewFS("testdata/fixtures/sys/issue770")
if err != nil {
t.Fatal(err)
}

mdraids, err := fs.Mdraids()
if err != nil {
t.Fatal(err)
}

if len(mdraids) != 1 {
t.Fatalf("expected 1 mdraid, got %d", len(mdraids))
}

md := mdraids[0]
if md.SyncCompleted != 0 {
t.Fatalf("expected SyncCompleted=0 for 'delayed' state, got %f", md.SyncCompleted)
}
if md.SyncAction != "resync" {
t.Fatalf("expected SyncAction='resync', got '%s'", md.SyncAction)
}
}
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/array_state
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
clean
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/chunk_size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
524288
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/degraded
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/dev-sdaa/state
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
spare
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/dev-sdn/state
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
in_sync
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/dev-sdo/state
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
in_sync
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/dev-sdp/state
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
faulty
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/level
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
raid1
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/metadata_version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1.2
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/raid_disks
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/sync_action
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
resync
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/sync_completed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
delayed
1 change: 1 addition & 0 deletions testdata/issue770/block/md127/md/uuid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
7615b98d-f2ba-4d99-bee8-6202d8e130b9