Skip to content

fix(desktop): evaluate MAKE_OPTS so macOS Ruby build gets a valid -jN #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luizeof merged 1 commit into from
Jul 18, 2026
Merged

fix(desktop): evaluate MAKE_OPTS so macOS Ruby build gets a valid -jN #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions desktop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,14 @@ step_4() {
echo "Checking Ruby 3.3.0..."
if ! user_do rbenv versions --bare | grep -q "^3.3.0$"; then
echo "Compiling Ruby 3.3.0 (this may take a few minutes)..."
# Optimization: Skip documentation and use parallel compilation
user_do bash -c "export RUBY_CONFIGURE_OPTS='--disable-install-doc'; export MAKE_OPTS='-j\$(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null || echo 2)'; rbenv install 3.3.0"
# Optimization: Skip documentation and use parallel compilation.
# Use single quotes for the outer `bash -c` and double quotes for the
# values so $(...) is evaluated by the inner shell. With the previous
# double-quoted outer + single-quoted, escaped \$(...), MAKE_OPTS was
# stored literally as "-j$(nproc ...)" and ruby-build ran a broken
# `make "-j$(nproc" ...`, failing the build (and cascading the Rails
# install onto system Ruby). Mirrors the Linux path below.
user_do bash -c 'export RUBY_CONFIGURE_OPTS="--disable-install-doc"; export MAKE_OPTS="-j$(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null || echo 2)"; rbenv install 3.3.0'
user_do rbenv global 3.3.0
fi

Expand Down