Repository navigation
Conversation
A bare function was accepted at construction and failed at the first escalation with AttributeError. It is now wrapped in CallbackApprovalHandler like ApprovalPolicy(handler=...) does; anything else raises TypeError up front. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| # A bare function, as ApprovalPolicy(handler=...) accepts; it used | ||
| # to pass here and fail at the first escalation. | ||
| from .approval import CallbackApprovalHandler |
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoApprovalClassifier(fallback=some_function)was accepted when built and then failed at the first escalation withAttributeError: 'function' object has no attribute 'request_approval'.ApprovalPolicy(handler=...)andbuild_agent(approval=...)accept bare functions, so this was inconsistent. Found while reviewing the policy-as-code guide.approval_classifier.py: a callable fallback is wrapped inCallbackApprovalHandler(plain or async, returningApprovalDecisionor bool); anything else raisesTypeErrorat construction.TestFunctionFallback(async function, plain function returning bool, non-callable rejected); all three fail before and pass after. Approval suites: 236 passed. Held for the next release.🤖 Generated with Claude Code