Fix CLI app name normalization and make typegen API deps optional#195
Merged
Fix CLI app name normalization and make typegen API deps optional#195
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6da0c9a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR defaults the CLI scaffold UI to shadcn (removing Mantine templates and the --ui flag), normalizes project names (spaces → dashes, lowercase, "." → cwd basename), writes CLAUDE.md and a .cursorignore on scaffolds, and makes Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant CLI
participant Parser as NameParser
participant Planner as InitPlanner
participant Scaffold
participant FS as FileSystem
User->>CLI: proofkit init <name>
CLI->>Parser: parseNameAndPath(raw)
Parser-->>CLI: normalizedName, path
CLI->>Planner: runInit(state ui="shadcn")
Planner->>Scaffold: scaffoldProject(nextjs-shadcn)
Scaffold->>FS: copy template files
Scaffold->>FS: write `CLAUDE.md`
Scaffold->>FS: write `.cursorignore` ("CLAUDE.md\n")
FS-->>User: project created
sequenceDiagram
autonumber
actor Caller
participant Typegen
participant Loader as DynamicLoader
participant Fmdapi as "@proofkit/fmdapi"
participant Fmodata as "@proofkit/fmodata"
Caller->>Typegen: generateTypedClients(config)
alt config.type == "fmodata"
Typegen->>Loader: await import("./fmodata/typegen")
Loader->>Fmodata: try load
alt missing
Loader-->>Typegen: missing-dep → rethrowMissingDependency
else loaded
Fmodata-->>Typegen: run generation
end
else config.type == "fmdapi"
Typegen->>Loader: await import("@proofkit/fmdapi") & helpers
Loader->>Fmdapi: try load
alt missing
Loader-->>Typegen: missing-dep → rethrowMissingDependency
else loaded
Fmdapi-->>Typegen: provide client/adapters
end
end
Typegen-->>Caller: generated outputs / errors
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/cli/src/helpers/createProject.ts (1)
74-85:⚠️ Potential issue | 🟠 MajorReject unsupported UIs before
scaffoldProject().This is the first runtime check that treats non-
shadcnvalues as invalid, butscaffoldProject()already ran on Line 33. A legacystate.ui === "mantine"will leave a partially scaffolded project on disk and only then throw here.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/src/helpers/createProject.ts` around lines 74 - 85, Reject unsupported UI values before calling scaffoldProject(): validate state.ui at the start of the createProject flow and throw for anything other than "shadcn" (or allowed values) so scaffoldProject() and subsequent operations (like addPackageDependency) never run when UI is unsupported; update the check that currently throws after addPackageDependency to run earlier (e.g., before scaffoldProject() is invoked) and reference state.ui, scaffoldProject(), and addPackageDependency to locate and modify the logic.
🧹 Nitpick comments (3)
packages/cli/src/state.ts (1)
10-10: Schema still accepts"mantine"but support has been removed.The
uifield schema allows"mantine"as a valid value, but the template service inlive.tsnow ignores theuiparameter entirely and always usesnextjs-shadcn. Consider restricting the enum to only"shadcn"or removing theuifield altogether to avoid confusion:♻️ Option 1: Restrict to shadcn only
- ui: z.enum(["shadcn", "mantine"]).optional().catch("shadcn"), + ui: z.literal("shadcn").optional().catch("shadcn"),♻️ Option 2: Remove the field if no longer needed
If
uiis no longer a meaningful configuration option, consider removing it from the schema entirely to simplify the codebase.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/src/state.ts` at line 10, The schema still exposes the ui field (the z.enum([...]) call creating ui) allowing "mantine" even though live.ts/template service always uses nextjs-shadcn; either restrict the enum to only "shadcn" by changing the ui enum to z.enum(["shadcn"]).optional().catch("shadcn"), or remove the ui property from the exported schema entirely if it is no longer used—also search for any consumers referencing the ui symbol and remove or adapt them so the schema and runtime behavior remain consistent.packages/typegen/src/getLayoutMetadata.ts (1)
6-13: Prefer narrowing-only access ingetErrorCode.
getErrorCodecurrently uses a type assertion (error as { code?: unknown }). You can avoid assertions entirely here.♻️ Proposed refactor
function getErrorCode(error: unknown): string | undefined { if (!error || typeof error !== "object" || !("code" in error)) { return undefined; } - const { code } = error as { code?: unknown }; + const code = Reflect.get(error, "code"); return typeof code === "string" ? code : undefined; }As per coding guidelines, "Leverage TypeScript's type narrowing instead of type assertions."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/typegen/src/getLayoutMetadata.ts` around lines 6 - 13, The function getErrorCode currently uses a type assertion to extract code; change it to rely on TypeScript narrowing by checking error !== null && typeof error === "object" && "code" in error, then read code from the narrowed object (e.g., inside that guarded block access error.code) and return it only if typeof code === "string"; update the function to remove the "error as { code?: unknown }" assertion and use the narrowed variable (getErrorCode).packages/cli/src/utils/validateAppName.ts (1)
10-23: Please route this legacy validator through~/utils/projectName.ts.This copy still splits only on
/, while the shared helper now normalizes\first. Inputs likeapps\\My Appwill validate differently depending on which module a caller imports. Re-exporting the shared implementation would keep future normalization fixes in one place.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/src/utils/validateAppName.ts` around lines 10 - 23, Replace the local legacy validation logic in validateAppName.ts with a re-export or wrapper around the shared validator in ~/utils/projectName.ts: import the projectName normalization/validation function from that module and call it instead of using the local removeTrailingSlash/whitespaceRegex/split-on-"/" logic (including the appName, indexOfDelimiter, and "." basename handling) so backslash normalization and other fixes from projectName.ts are applied consistently; keep the external API the same by exporting the shared function from validateAppName.ts (or returning its result) so callers are unaffected.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/cli/src/core/planInit.ts`:
- Around line 87-92: The current init plan unconditionally writes
".cursorignore" via the writes entry (path.join(targetDir, ".cursorignore")),
which will overwrite any existing ignore entries; update the init flow so that
before writing you read the existing ".cursorignore" (use the same target path
used in the writes entry and the logic in executeInitPlan.ts that currently uses
fs.writeFile), check whether the line "CLAUDE.md" already exists (account for
trailing newlines), and only append that line if it's missing, otherwise leave
the file unchanged; if the file does not exist create it with "CLAUDE.md\n".
Ensure this logic lives in the code path that processes the writes array (or
replace the writes entry with a preparatory read/merge step) so existing entries
are preserved.
In `@packages/cli/src/utils/parseNameAndPath.ts`:
- Around line 22-25: The function parseNameAndPath currently normalizes the
entire input before splitting, which rewrites parent directories; change it to
first call removeTrailingSlash(rawInput) and split that result by "/" into
segments, then only normalize the final segment (the project/package name) using
.replace(whitespaceRegex, "-").toLowerCase(); leave all leading directory
segments verbatim. Update references in parseNameAndPath to use the split
segments and the normalized last segment (keep removeTrailingSlash and
whitespaceRegex usage, but apply them only to the last path element).
In `@packages/cli/src/utils/projectName.ts`:
- Around line 16-22: parseNameAndPath currently normalizes the whole input via
normalizeProjectNameForPackage which lowercases leading directories; instead
split the raw projectName by "/", detect if the package is scoped (if the
penultimate segment startsWith("@") then treat the last two segments as the
package scope+name, otherwise the last segment is the package), normalize only
those package segments using normalizeProjectNameForPackage (apply it to each
package segment), then reconstruct scopedAppName from the normalized package
segments and build appDir by joining the original leading directories (preserve
their exact casing) with the normalized package segments; update
parseNameAndPath to use this logic and keep normalizeProjectNameForPackage only
for package/scope segments.
In `@packages/typegen/src/server/createDataApiClient.ts`:
- Around line 203-218: The catch block in createDataApiClient (around
FMServerConnection creation after loadFmodataDeps) currently maps all errors to
a 500/unknown; change it to detect malformed server URL errors (thrown by the
URL constructor inside FMServerConnection) and return a 400 response with kind:
"adapter_error", suspectedField: "server" and the error message; otherwise keep
the existing 500/unknown behavior — i.e., if error is a TypeError whose message
indicates an invalid/malformed URL (e.g., message contains "Invalid URL" or
similar), return { error: error.message, statusCode: 400, kind: "adapter_error",
suspectedField: "server" }, else return the current 500 object.
- Around line 13-17: The exported CreateClientResult currently exposes
clientTypes.LayoutOrFolder[] via the client.layouts signature which leaks the
`@proofkit/fmdapi` peer type; change the public surface so CreateClientResult does
not reference clientTypes directly — either replace client.layouts' return type
with a package-local structural type (e.g., declare a local LayoutOrFolder shape
used in the client: { layouts?: () => Promise<{ layouts: LocalLayoutOrFolder[]
}>; }) or make the client property opaque (e.g., layouts returns unknown/any)
and perform any narrowing inside app.ts; update the CreateClientResult/interface
that contains client and the layouts method signature (and any related exports)
accordingly so no clientTypes.* symbol appears in this module's exported types.
---
Outside diff comments:
In `@packages/cli/src/helpers/createProject.ts`:
- Around line 74-85: Reject unsupported UI values before calling
scaffoldProject(): validate state.ui at the start of the createProject flow and
throw for anything other than "shadcn" (or allowed values) so scaffoldProject()
and subsequent operations (like addPackageDependency) never run when UI is
unsupported; update the check that currently throws after addPackageDependency
to run earlier (e.g., before scaffoldProject() is invoked) and reference
state.ui, scaffoldProject(), and addPackageDependency to locate and modify the
logic.
---
Nitpick comments:
In `@packages/cli/src/state.ts`:
- Line 10: The schema still exposes the ui field (the z.enum([...]) call
creating ui) allowing "mantine" even though live.ts/template service always uses
nextjs-shadcn; either restrict the enum to only "shadcn" by changing the ui enum
to z.enum(["shadcn"]).optional().catch("shadcn"), or remove the ui property from
the exported schema entirely if it is no longer used—also search for any
consumers referencing the ui symbol and remove or adapt them so the schema and
runtime behavior remain consistent.
In `@packages/cli/src/utils/validateAppName.ts`:
- Around line 10-23: Replace the local legacy validation logic in
validateAppName.ts with a re-export or wrapper around the shared validator in
~/utils/projectName.ts: import the projectName normalization/validation function
from that module and call it instead of using the local
removeTrailingSlash/whitespaceRegex/split-on-"/" logic (including the appName,
indexOfDelimiter, and "." basename handling) so backslash normalization and
other fixes from projectName.ts are applied consistently; keep the external API
the same by exporting the shared function from validateAppName.ts (or returning
its result) so callers are unaffected.
In `@packages/typegen/src/getLayoutMetadata.ts`:
- Around line 6-13: The function getErrorCode currently uses a type assertion to
extract code; change it to rely on TypeScript narrowing by checking error !==
null && typeof error === "object" && "code" in error, then read code from the
narrowed object (e.g., inside that guarded block access error.code) and return
it only if typeof code === "string"; update the function to remove the "error as
{ code?: unknown }" assertion and use the narrowed variable (getErrorCode).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9eef0720-f258-4084-9cb2-2ddb1a683110
⛔ Files ignored due to path filters (2)
packages/cli/template/nextjs-mantine/public/favicon.icois excluded by!**/*.icopackages/cli/template/nextjs-mantine/public/proofkit.pngis excluded by!**/*.png
📒 Files selected for processing (69)
.changeset/clean-suns-matter.md.changeset/cli-init-claude-cursorignore.md.changeset/fix-cli-dot-name-normalization.md.changeset/mean-worms-notice.md.changeset/remove-cli-ui-flag.md.changeset/soften-project-name-spaces.md.changeset/tidy-dots-speak.mdapps/docs/src/app/layout.tsxpackages/cli/src/cli/init.tspackages/cli/src/core/planInit.tspackages/cli/src/helpers/createProject.tspackages/cli/src/helpers/scaffoldProject.tspackages/cli/src/index.tspackages/cli/src/services/live.tspackages/cli/src/state.tspackages/cli/src/utils/parseNameAndPath.tspackages/cli/src/utils/projectName.tspackages/cli/src/utils/validateAppName.tspackages/cli/template/nextjs-mantine/AGENTS.mdpackages/cli/template/nextjs-mantine/CLAUDE.mdpackages/cli/template/nextjs-mantine/README.mdpackages/cli/template/nextjs-mantine/_gitignorepackages/cli/template/nextjs-mantine/components.jsonpackages/cli/template/nextjs-mantine/next.config.tspackages/cli/template/nextjs-mantine/package.jsonpackages/cli/template/nextjs-mantine/postcss.config.cjspackages/cli/template/nextjs-mantine/proofkit.jsonpackages/cli/template/nextjs-mantine/src/app/(main)/layout.tsxpackages/cli/template/nextjs-mantine/src/app/(main)/page.tsxpackages/cli/template/nextjs-mantine/src/app/layout.tsxpackages/cli/template/nextjs-mantine/src/app/navigation.tsxpackages/cli/template/nextjs-mantine/src/components/AppLogo.tsxpackages/cli/template/nextjs-mantine/src/components/AppShell/internal/AppShell.tsxpackages/cli/template/nextjs-mantine/src/components/AppShell/internal/Header.module.csspackages/cli/template/nextjs-mantine/src/components/AppShell/internal/Header.tsxpackages/cli/template/nextjs-mantine/src/components/AppShell/internal/HeaderMobileMenu.tsxpackages/cli/template/nextjs-mantine/src/components/AppShell/internal/HeaderNavLink.tsxpackages/cli/template/nextjs-mantine/src/components/AppShell/internal/config.tspackages/cli/template/nextjs-mantine/src/components/AppShell/slot-header-center.tsxpackages/cli/template/nextjs-mantine/src/components/AppShell/slot-header-left.tsxpackages/cli/template/nextjs-mantine/src/components/AppShell/slot-header-mobile-content.tsxpackages/cli/template/nextjs-mantine/src/components/AppShell/slot-header-right.tsxpackages/cli/template/nextjs-mantine/src/config/env.tspackages/cli/template/nextjs-mantine/src/config/theme/globals.csspackages/cli/template/nextjs-mantine/src/config/theme/mantine-theme.tspackages/cli/template/nextjs-mantine/src/server/safe-action.tspackages/cli/template/nextjs-mantine/src/utils/notification-helpers.tspackages/cli/template/nextjs-mantine/src/utils/styles.tspackages/cli/template/nextjs-mantine/tsconfig.jsonpackages/cli/template/nextjs-shadcn/CLAUDE.mdpackages/cli/template/nextjs-shadcn/CLAUDE.mdpackages/cli/template/vite-wv/CLAUDE.mdpackages/cli/template/vite-wv/CLAUDE.mdpackages/cli/tests/cli.test.tspackages/cli/tests/init-fixtures.tspackages/cli/tests/init-non-interactive-failures.test.tspackages/cli/tests/init-run-init-regression.test.tspackages/cli/tests/init-scaffold-contract.test.tspackages/cli/tests/integration.test.tspackages/cli/tests/legacy-project-name-utils.test.tspackages/cli/tests/project-name.test.tspackages/cli/tests/test-layer.tspackages/typegen/package.jsonpackages/typegen/src/cli.tspackages/typegen/src/getLayoutMetadata.tspackages/typegen/src/optionalDeps.tspackages/typegen/src/server/app.tspackages/typegen/src/server/createDataApiClient.tspackages/typegen/src/typegen.ts
💤 Files with no reviewable changes (31)
- packages/cli/template/nextjs-mantine/src/components/AppLogo.tsx
- packages/cli/template/nextjs-mantine/CLAUDE.md
- packages/cli/template/nextjs-mantine/src/components/AppShell/internal/Header.module.css
- packages/cli/template/nextjs-mantine/postcss.config.cjs
- packages/cli/template/nextjs-mantine/src/components/AppShell/internal/config.ts
- packages/cli/template/nextjs-mantine/src/app/(main)/layout.tsx
- packages/cli/template/nextjs-mantine/next.config.ts
- packages/cli/template/nextjs-mantine/_gitignore
- packages/cli/template/nextjs-mantine/src/server/safe-action.ts
- packages/cli/template/nextjs-mantine/AGENTS.md
- packages/cli/template/nextjs-mantine/src/components/AppShell/internal/HeaderMobileMenu.tsx
- packages/cli/template/nextjs-mantine/src/components/AppShell/slot-header-left.tsx
- packages/cli/template/nextjs-mantine/src/config/env.ts
- packages/cli/template/nextjs-mantine/src/config/theme/globals.css
- packages/cli/template/nextjs-mantine/src/components/AppShell/slot-header-right.tsx
- packages/cli/template/nextjs-mantine/src/utils/styles.ts
- packages/cli/template/nextjs-mantine/README.md
- packages/cli/template/nextjs-mantine/proofkit.json
- packages/cli/template/nextjs-mantine/src/config/theme/mantine-theme.ts
- packages/cli/template/nextjs-mantine/src/components/AppShell/internal/HeaderNavLink.tsx
- packages/cli/template/nextjs-mantine/src/components/AppShell/slot-header-center.tsx
- packages/cli/template/nextjs-mantine/tsconfig.json
- packages/cli/template/nextjs-mantine/src/app/layout.tsx
- packages/cli/template/nextjs-mantine/components.json
- packages/cli/template/nextjs-mantine/src/app/(main)/page.tsx
- packages/cli/template/nextjs-mantine/src/components/AppShell/internal/AppShell.tsx
- packages/cli/template/nextjs-mantine/package.json
- packages/cli/template/nextjs-mantine/src/components/AppShell/internal/Header.tsx
- packages/cli/template/nextjs-mantine/src/app/navigation.tsx
- packages/cli/template/nextjs-mantine/src/utils/notification-helpers.ts
- packages/cli/template/nextjs-mantine/src/components/AppShell/slot-header-mobile-content.tsx
- keep leading path segments verbatim - normalize only final package segment - add regression coverage
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+25
to
+29
| const normalizedPaths = [...paths]; | ||
| const lastPathIndex = normalizedPaths.length - 1; | ||
|
|
||
| let appName = paths.at(-1) ?? ""; | ||
| let appName = (normalizedPaths.at(-1) ?? "").replace(whitespaceRegex, "-").toLowerCase(); | ||
| normalizedPaths[lastPathIndex] = appName; |
Contributor
There was a problem hiding this comment.
Critical Bug: Incorrect normalization order for scoped packages
The code normalizes only the last path segment before checking for scoped packages:
let appName = (normalizedPaths.at(-1) ?? "").replace(whitespaceRegex, "-").toLowerCase();
normalizedPaths[lastPathIndex] = appName;But when a scoped package is detected, it joins from normalizedPaths which has only the last segment normalized:
appName = normalizedPaths.slice(indexOfDelimiter).join("/");Example: Input "@My Scope/My App" produces paths = ["@My Scope", "My App"], then normalizedPaths = ["@My Scope", "my-app"], and finally appName = "@My Scope/my-app" (scope not normalized).
This conflicts with projectName.ts which normalizes ALL package segments. The scope segment "@My Scope" should be normalized to "@my-scope". Fix by normalizing the scope segment:
const indexOfDelimiter = normalizedPaths.findIndex((p) => p.startsWith("@"));
if (indexOfDelimiter !== -1) {
// Normalize the scope segment as well
normalizedPaths[indexOfDelimiter] = normalizedPaths[indexOfDelimiter].replace(whitespaceRegex, "-").toLowerCase();
appName = normalizedPaths.slice(indexOfDelimiter).join("/");
}
Suggested change
| const normalizedPaths = [...paths]; | |
| const lastPathIndex = normalizedPaths.length - 1; | |
| let appName = paths.at(-1) ?? ""; | |
| let appName = (normalizedPaths.at(-1) ?? "").replace(whitespaceRegex, "-").toLowerCase(); | |
| normalizedPaths[lastPathIndex] = appName; | |
| const normalizedPaths = [...paths]; | |
| const lastPathIndex = normalizedPaths.length - 1; | |
| let appName = (normalizedPaths.at(-1) ?? "").replace(whitespaceRegex, "-").toLowerCase(); | |
| normalizedPaths[lastPathIndex] = appName; | |
| const indexOfDelimiter = normalizedPaths.findIndex((p) => p.startsWith("@")); | |
| if (indexOfDelimiter !== -1) { | |
| // Normalize the scope segment as well | |
| normalizedPaths[indexOfDelimiter] = normalizedPaths[indexOfDelimiter].replace(whitespaceRegex, "-").toLowerCase(); | |
| appName = normalizedPaths.slice(indexOfDelimiter).join("/"); | |
| } | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/typegen/src/server/createDataApiClient.ts (1)
2-2: Please verify the shared env helper is still peer-agnostic.Lines 2, 52, and 164 still pull
OttoAPIKeyfrom@proofkit/fmdapiinto the shared auth path. If this module is source-exported or its declarations preserve that import, OData-only consumers still need the optional peer to resolve types. Keeping the shared auth shape local (string) and narrowing only inside the Otto branch would remove that remaining compile-time edge. As per coding guidelines, "Leverage TypeScript's type narrowing instead of type assertions".Also applies to: 46-53, 160-165
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/typegen/src/server/createDataApiClient.ts`:
- Around line 67-72: The exported OdataClientError type is too narrow compared
to actual errors returned (e.g., errors from getEnvVarsFromConfig are returned
verbatim); update the OdataClientError interface to include the additional
fields returned such as message?: string and details?: unknown (or a more
specific shape if known) so callers retain typed access to structured payloads;
locate the OdataClientError declaration and add these fields, and ensure code
paths that return env/config errors (the code that calls getEnvVarsFromConfig)
are still compatible with the widened type.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 340a318a-9dcb-453a-a1d2-e8d84e1f8080
📒 Files selected for processing (1)
packages/typegen/src/server/createDataApiClient.ts
- Refresh pnpm lock resolution - Rehome fmdapi/fmodata dev deps
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
- include `message` and `details` on client errors - add changeset for `@proofkit/typegen` patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nextjs-mantineCLI template and related agent/docs files@proofkit/fmdapiand@proofkit/fmodataoptional peers in@proofkit/typegenTesting
pnpm run ciSummary by CodeRabbit
New Features
Changed Behavior