Handle empty FM bridge with fallback shim by eluce2 · Pull Request #196 · proofsh/proofkit

eluce2 · 2026-03-20T22:11:30Z

Summary

soften FM bridge startup when MCP responds but no FileMaker file is connected
warn once at startup, then inject a fallback filemaker / FileMaker shim that logs runtime errors on use
keep unhealthy or unreachable MCP behavior as a hard setup failure
add tests for null discovery, warning path, and fallback runtime logging

Testing

Not run
Added coverage in packages/webviewer/tests/vite-plugins.test.ts
pnpm run ci not run in this branch

Summary by CodeRabbit

New Features
- Dev server now continues with a warning when no FileMaker files are connected and injects a fallback bridge script.
Bug Fixes
- Fallback bridge produces clear runtime error logs if bridge calls occur before any file connects.
Tests
- Added tests covering the no-connected-files warning, fallback injection, and runtime error behavior.

- warn when FM MCP has no connected files - inject fallback bridge shim and runtime error logging - update types and tests

changeset-bot · 2026-03-20T22:11:34Z

🦋 Changeset detected

Latest commit: 38c126e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@proofkit/webviewer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-03-20T22:11:35Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
proofkit-docs	Ready	Preview	Mar 20, 2026 10:21pm

pkg-pr-new · 2026-03-20T22:14:11Z

Open in StackBlitz

@proofkit/better-auth

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/better-auth@196

@proofkit/cli

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/cli@196

create-proofkit

pnpm add https://pkg.pr.new/proofgeist/proofkit/create-proofkit@196

@proofkit/fmdapi

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmdapi@196

@proofkit/fmodata

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmodata@196

@proofkit/typegen

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/typegen@196

@proofkit/webviewer

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/webviewer@196

commit: 5dda815

coderabbitai · 2026-03-20T22:14:59Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: de8897d5-d5a0-499e-9bfb-d3e288673b16

📥 Commits

Reviewing files that changed from the base of the PR and between 5dda815 and 38c126e.

📒 Files selected for processing (1)

packages/webviewer/src/types.d.ts

📝 Walkthrough

Walkthrough

When the FM MCP responds but reports no connected files, the Vite FM bridge now emits a server-side warning, injects a fallback bridge shim into index.html, and the shim logs runtime errors if bridge methods are invoked before any file connects. Setup still fails when the MCP is unreachable/unhealthy.

Changes

Cohort / File(s)	Summary
Bridge logic `packages/webviewer/src/fm-bridge.ts`	Added `buildNoConnectedFilesWarning`, `buildNoConnectedFilesRuntimeError`, `buildNoConnectedFilesScriptTag`. `discoverConnectedFileName()` now returns `Promise<string \| null>` and server/plugin flow emits a warning and injects a fallback shim when no filename is discovered.
Type definitions `packages/webviewer/src/types.d.ts`	Extended global `Window` with optional `FileMaker` and `filemaker` members to reflect possible runtime shim signatures.
Tests & Changeset `packages/webviewer/tests/vite-plugins.test.ts`, `.changeset/fm-bridge-empty-connected-files.md`	Updated tests to expect `null` from empty connected-files payload, added assertions for `console.warn` emission and injected fallback script, and tests that the fallback logs runtime errors. Added changeset describing patch bump.

Sequence Diagram(s)

sequenceDiagram
  participant Dev as Dev Server (Vite fmBridge)
  participant MCP as FM MCP (connected-files endpoint)
  participant Browser as Browser (index.html / runtime)

  Dev->>MCP: GET /connected-files
  alt MCP returns filename
    MCP-->>Dev: { filename: "MyFile" }
    Dev->>Browser: inject mock bridge script (head-prepend) referencing "MyFile"
  else MCP returns no files
    MCP-->>Dev: { files: [] } or payload with no usable filename
    Dev-->>Dev: emit console.warn("no connected files")
    Dev->>Browser: inject fallback shim script that stubs window.filemaker / window.FileMaker
  end

  Note right of Browser: At runtime, when app calls bridge methods
  Browser->>Browser: call window.filemaker / FileMaker.PerformScript
  alt fallback shim active (no connected file)
    Browser-->>Browser: console.error("bridge used before any file connected") xN
  else real bridge connected
    Browser->>MCP: forward calls to connected file via bridge
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

fm bridge vite plugin #150: Modifies the same fm-bridge.ts plugin and related discovery/bridge behavior; likely directly related.

Suggested reviewers

toddgeist

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Handle empty FM bridge with fallback shim' accurately summarizes the main change: introducing fallback behavior when no FileMaker files are connected, replacing hard failure with a warning and shim.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch t3code/fm-bridge-warning-fallback

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

packages/webviewer/src/types.d.ts (1)

3-7: Consider adding FileMaker to the Window interface.

The fallback shim in buildNoConnectedFilesScriptTag also injects window.FileMaker with PerformScript and PerformScriptWithOption methods. The test at line 279 accesses globalThis.window.FileMaker?.PerformScript(...), but FileMaker isn't typed here.

💡 Suggested type addition

 interface Window {
   handleFmWVFetchCallback: (data: unknown, fetchId: string) => boolean;
   filemaker?: {
     (...args: unknown[]): unknown;
     performScript?: (...args: unknown[]) => unknown;
     performScriptWithOption?: (...args: unknown[]) => unknown;
   };
+  FileMaker?: {
+    PerformScript?: (...args: unknown[]) => unknown;
+    PerformScriptWithOption?: (...args: unknown[]) => unknown;
+  };
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/webviewer/src/types.d.ts` around lines 3 - 7, Add a FileMaker
definition to the global Window types so TypeScript knows about the fallback
shim injected by buildNoConnectedFilesScriptTag: update
packages/webviewer/src/types.d.ts to include a FileMaker property on the Window
interface (or augment globalThis) that defines PerformScript and
PerformScriptWithOption (and optional lowercase aliases if used) as callable
methods; ensure the symbol names match what tests reference (window.FileMaker,
PerformScript, PerformScriptWithOption) so
globalThis.window.FileMaker?.PerformScript(...) is correctly typed.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/webviewer/src/types.d.ts`:
- Around line 3-7: Add a FileMaker definition to the global Window types so
TypeScript knows about the fallback shim injected by
buildNoConnectedFilesScriptTag: update packages/webviewer/src/types.d.ts to
include a FileMaker property on the Window interface (or augment globalThis)
that defines PerformScript and PerformScriptWithOption (and optional lowercase
aliases if used) as callable methods; ensure the symbol names match what tests
reference (window.FileMaker, PerformScript, PerformScriptWithOption) so
globalThis.window.FileMaker?.PerformScript(...) is correctly typed.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 273b0deb-39a6-460d-b49d-6b5a6bb87804

📥 Commits

Reviewing files that changed from the base of the PR and between e93ba31 and 5dda815.

📒 Files selected for processing (4)

.changeset/fm-bridge-empty-connected-files.md
packages/webviewer/src/fm-bridge.ts
packages/webviewer/src/types.d.ts
packages/webviewer/tests/vite-plugins.test.ts

- type `window.FileMaker` fallback bridge - keep webviewer typings aligned with bridge API

Handle empty FM bridge connections with fallback

5dda815

- warn when FM MCP has no connected files - inject fallback bridge shim and runtime error logging - update types and tests

vercel bot deployed to Preview March 20, 2026 22:13 View deployment

coderabbitai bot reviewed Mar 20, 2026

View reviewed changes

Add FileMaker bridge fallback types

38c126e

- type `window.FileMaker` fallback bridge - keep webviewer typings aligned with bridge API

eluce2 merged commit 3239cde into main Mar 20, 2026
8 of 10 checks passed

vercel bot deployed to Preview March 20, 2026 22:21 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle empty FM bridge with fallback shim#196

Handle empty FM bridge with fallback shim#196
eluce2 merged 2 commits intomainfrom
t3code/fm-bridge-warning-fallback

eluce2 commented Mar 20, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 20, 2026

Uh oh!

coderabbitai bot commented Mar 20, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

eluce2 commented Mar 20, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 20, 2026

Uh oh!

coderabbitai bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

eluce2 commented Mar 20, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 20, 2026 •

edited

Loading

vercel bot commented Mar 20, 2026 •

edited

Loading

coderabbitai bot commented Mar 20, 2026 •

edited

Loading