fix(hindsight): honor BLOCKLIST_CONFIG in the monitor - #322
Open
kayibal wants to merge 1 commit into
Open
Conversation
The monitor never read the blocklist: fynd serve declares --blocklist-config (env BLOCKLIST_CONFIG) and passes it to the builder, but MonitorArgs had no such flag, so the deployment's mounted blocklist.toml and env var were silently ignored — blocklisted pools (e.g. curve tricrypto2) streamed anyway. Add the flag with the same semantics as serve: load the TOML when set, fall back to tycho-simulation's embedded default blocklist otherwise. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
| Some(path) => fynd_rpc::config::BlocklistConfig::load_from_file(path) | ||
| .map_err(|e| anyhow::anyhow!("failed to load blocklist config: {e}"))? | ||
| .into_components(), | ||
| None => tycho_simulation::utils::default_blocklist(), |
Collaborator
There was a problem hiding this comment.
tycho-simulation already auto-applies the default blocklist so you do not need to explicitly do it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hindsight monitor never read the blocklist.
fynd servedeclares--blocklist-config(envBLOCKLIST_CONFIG) and wires it into the feed, butMonitorArgshad no such flag — clap only binds declared env vars, so the prod deployment's mounted/app/blocklist.tomlandBLOCKLIST_CONFIGenv var were silently ignored. Observed live: blocklisted pools (curve tricrypto2 among them) streaming into the monitor's market and logging spot-price warnings.This adds
--blocklist-configto the monitor with the same semantics as serve: load the TOML when set, fall back to tycho-simulation's embedded default blocklist when unset. The existing prod helm config (env + ConfigMap mount) starts working with zero changes once this deploys.Related: helm-configuration#783 removes the temp Curve entries from that blocklist (obsolete since 0.90.3's
curve_filter); the remaining entries (AMPL, Fluid Lite, "Dollars" pools) only take effect with this fix.🤖 Generated with Claude Code