feat: count exclusive candidates dropped for invalid route shape - #445
Merged
Conversation
Contributor
Author
|
Reopening. The shape rule is still on main, so this is the number that sizes whether removing it is worth doing. #446 sketched the removal and was closed on cost: the conversion is a bisection over route replays, and a |
tamaralipows
marked this pull request as ready for review
August 20, 2026 19:20
tamaralipows
force-pushed
the
tnl/exclusive-route-rejection-metric
branch
from
August 20, 2026 19:35
2d9a575 to
76f8f4f
Compare
Breaking API Changes DetectedThis PR introduces breaking API changes, but the PR title does not declare them.
semver-checks output |
An exclusive leg that does not reach the route's output token makes the candidate unusable, so no commitment is made and the order falls back to public liquidity. That happened silently. `exclusive_route_invalid_shape_total` counts it, which sizes how much exclusive liquidity the shape rule turns away. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tamaralipows
force-pushed
the
tnl/exclusive-route-rejection-metric
branch
from
August 20, 2026 19:41
76f8f4f to
dd16584
Compare
PierreMkt
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exclusive leg that does not reach the route's output token makes the candidate unusable, so no commitment is made and the order falls back to public liquidity. That happened silently.
exclusive_route_invalid_shape_totalcounts it:It counts only the wrong-position case, not routes that carry no exclusive leg at all — those are pools routing around the exclusive components, not rejections, and they would swamp the series.
The counter fires per exclusive-scope candidate, not per order. An order served by several exclusive-scope pools contributes several increments.
🤖 Generated with Claude Code