Support offscreencanvas when possible#355
Open
LukeWood wants to merge 1 commit intoprotectwise:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't put it behind a feature flag, but I did it only when WorkerGlobalScope is defined which is only the case in WebWorkers: https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope
Maybe we should unit test this, but I think this looks fine. My own implementation was typescript so I had to port it a bit. Its possible I made a mistake in translation, so give it a solid look.