Skip to content

Add optional commit signing and post-processor max_idle#62

Open
BowTiedRadone wants to merge 8 commits intoprotocol-security:masterfrom
BowTiedRadone:feat/optional-signing
Open

Add optional commit signing and post-processor max_idle#62
BowTiedRadone wants to merge 8 commits intoprotocol-security:masterfrom
BowTiedRadone:feat/optional-signing

Conversation

@BowTiedRadone
Copy link
Copy Markdown
Contributor

@BowTiedRadone BowTiedRadone commented Apr 11, 2026

Summary

This PR adds support for optional SSH commit signing via git_user.signing_key and post-processor-specific max_idle, inheriting top-level by default. These are features that help end-to-end automation needs encountered in our personal real world setup at Stacks.

Changes

  • launch.sh: Parse signing_key with $VAR/~ expansion, mount into container. Parse post_process.max_idle with fallback to top-level max_idle.
  • lib/harness.sh: Enable gpg.format ssh and commit.gpgsign true when /etc/swarm/signing_key exists; disable signing otherwise.
  • Dockerfile: Add openssh-client for SSH signing support.
  • README.md, USAGE.md: Document both features.
  • tests/test_config.sh: Signing key parsing, pp max_idle default/explicit/inheritance, kitchen-sink coverage.
  • tests/test_harness.sh: Rewrite signing test to exercise actual file-existence check.
  • tests/test_launch.sh: pp max_idle parsing, fix bare-repo test commits to disable signing via repo config.

Test plan

  • ./tests/test.sh --unit (932 tests pass)

@BowTiedRadone
Copy link
Copy Markdown
Contributor Author

Due to very limited bandwidth lately, I have included both features in a single PR. Can happily separate, but it will take some more time.

@moodmosaic
Copy link
Copy Markdown
Member

Thank you! 🚀 I'll look into it once I get #61 merged. 🙏


Due to very limited bandwidth lately, I have included both features in a single PR. Can happily separate, but it will take some more time.

That's OK(-ish) since the commits are well-crafted and autonomous.

@BowTiedRadone BowTiedRadone force-pushed the feat/optional-signing branch from 2bd1179 to 2dbc7c0 Compare April 14, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants