Add optional commit signing and post-processor max_idle#62
Open
BowTiedRadone wants to merge 8 commits intoprotocol-security:masterfrom
Open
Add optional commit signing and post-processor max_idle#62BowTiedRadone wants to merge 8 commits intoprotocol-security:masterfrom
BowTiedRadone wants to merge 8 commits intoprotocol-security:masterfrom
Conversation
91860b8 to
2bd1179
Compare
Contributor
Author
|
Due to very limited bandwidth lately, I have included both features in a single PR. Can happily separate, but it will take some more time. |
Member
2bd1179 to
2dbc7c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for optional SSH commit signing via
git_user.signing_keyand post-processor-specificmax_idle, inheriting top-level by default. These are features that help end-to-end automation needs encountered in our personal real world setup at Stacks.Changes
launch.sh: Parsesigning_keywith$VAR/~expansion, mount into container. Parsepost_process.max_idlewith fallback to top-levelmax_idle.lib/harness.sh: Enablegpg.format sshandcommit.gpgsign truewhen/etc/swarm/signing_keyexists; disable signing otherwise.Dockerfile: Addopenssh-clientfor SSH signing support.README.md,USAGE.md: Document both features.tests/test_config.sh: Signing key parsing, ppmax_idledefault/explicit/inheritance, kitchen-sink coverage.tests/test_harness.sh: Rewrite signing test to exercise actual file-existence check.tests/test_launch.sh: ppmax_idleparsing, fix bare-repo test commits to disable signing via repo config.Test plan
./tests/test.sh --unit(932 tests pass)