fix(reveng): restore local tshark workflow and align manual CI/docs - #56
Merged
Conversation
- repair demo YAML specs used by reveng generation and bool filter behavior - update helper scripts to use the real CLI, map DLT_USER0, and resolve output names - ignore downloaded real_sample captures in git - regenerate synthetic sample pcaps to match the verified tshark assertions
- document the actual local reveng flow: fetch, generate, test, and manual CI - switch the manual tshark workflow to a valid CLI probe using pc --help - remove machine-specific paths from the README
cherninkiy
force-pushed
the
copilot/create-demo-reveng-folder
branch
from
April 21, 2026 23:03
3d4fca9 to
9a806c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores the
demo/revengworkflow as a fully working local and CI-ready path, then aligns the manual tshark workflow and README with the actual commands that now pass locally.Changes
demo/revengexecution path so generation and tshark validation work end to end.pc, withprotocollabfallback),DLT_USER0,user_dltmapping for tshark and Wireshark,real_sample.*captures as ignored indemo/reveng/.gitignore.sample.pcapfixtures to match the now-verified tshark assertions.demo/reveng/README.mdso it documents the actual working flow:Validation
Local validation completed successfully:
./tools/fetch_samples.sh --forcepython tools/make_samples.py./tools/generate_all.sh./tools/test_dissectors.shResult:
28 passed0 failed0 skippedNotes
run_wireshark.shis functionally aligned with the rest of the workflow, but GUI launch could not be fully verified because the local Wireshark installation fails with a system-level shared-library error unrelated to this repository.workflow_dispatch.