Repository navigation
feat(characters): one animation over many directions, joined on this side - #78
Merged
Merged
Conversation
…side PixelLab starts a new animation group for every call to POST /v2/characters/animations: animation_group_id is extra_forbidden on the way in, and repeating animation_name or template_animation_id makes a second group rather than extending the first. So the directions of one motion cannot be joined on the provider, and this joins them here. - character animate refuses a direction the motion already holds, before anything is sent, naming what it holds and what it lacks; --again buys a second take. Animating a direction it lacks says where the frames join. - character show folds the groups of one motion into one animation and says how many PixelLab holds behind it. - The subject record gathers the animation runs of one motion into one animation over every direction they covered and every file they wrote, so inspect and the atlas built from it carry all of them. Names and direction labels coming back from the provider now reach a refusal and the terminal, so they go through the same control-character table the record already applies to a manifest. specs/characters-and-animation R2.39, R2.40, R4.5; specs/asset-workspace R7.5. Verified with scc validate --checks --pr: 1691 passed, 46 skipped, coverage 95.34%, ruff check and format clean, artifacts clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.