Repository navigation
feat(characters): character animate refuses an animation group - #86
Merged
Merged
Conversation
`object animate --into` is supported by the provider, so the flag is the obvious thing to reach for on a character too — and `POST /characters/animations` has `extra="forbid"`, answering `extra_forbidden` on `animation_group_id` (n-0054). The refusal now happens here, ahead of the `--action` check and before the character is read, naming the field and saying what reaches the missing directions instead: every direction in one call with `-d`, folded back by `character show`. `--into`, `--group` and `--animation-group-id` are accepted and hidden from `--help`: the option must be answered, not advertised. specs/characters-and-animation R2.45, task 7.5. Verified: uv run pytest tests/test_commands_character.py (204 passed), scc validate --checks --pr (1830 passed, coverage 95.34%, 0 findings), uv run ruff check . and ruff format --check .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.