Repository navigation
feat(assets): ship scc-plan-review, a reviewer that holds a draft plan to docs/ and the code - #57
Merged
Merged
Conversation
…n to docs/ and the code scc validate checks a plan's shape and nothing checked its substance: a plan could pass every validator while re-deciding an ADR, adding a dependency the stack never adopted, rebuilding what exists, or missing a seam. scc plan approve seals it, so the review has to land before the seal. - internal/assets/templates/agents/scc-plan-review.md: read-only agent, six passes (shape, context, settled decisions, rebuilt/assumed, tasks against done-when, direction); returns a rethink/refine/ready verdict, findings by severity, questions for the user and scc patch amendments. - ReviewAgents gains it on all three harnesses at effort high; assets.Version 37 -> 38, fingerprint updated. - scc-prd and scc-plan-run dispatch it before scc plan approve. No preloaded rule names it, so no session pays for it unless it approves a plan. - design/orchestration.md section 7 names three agents. - This workspace re-rendered onto template version 38 with scc update. Plan: plans/plan-review-agent.md. The agent's own prompt reviewed that plan before approval and found the stale design doc, now fixed. Verified: scc validate --checks --pr -> 12 validators, 0 findings, 1029 tests, 86.3% coverage; golangci-lint run clean; golangci-lint fmt --diff empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
scc validatechecks a plan's shape; nothing checked its substance. A plan could pass every validator while re-deciding an ADR, adding a dependencydocs/stack.mdnever adopted, rebuilding what already exists, or missing a seam.scc plan approveseals it, so the review has to land before the seal.scc-plan-review(internal/assets/templates/agents/scc-plan-review.md): read-only. Six passes — shape (scc validate), context is true, nothing settled re-decided, nothing rebuilt or assumed, tasks reach## Done when, direction. Returns arethink | refine | readyverdict, findings by severity, up to five questions for the user (relayed by the orchestrator), and amendments asscc patchcommands.ReviewAgentsfor Claude Code, Codex and opencode at efforthigh.assets.Version37 -> 38, fingerprint updated.scc-prdandscc-plan-rundispatch it beforescc plan approve. No preloaded rule names it, so no session pays for it unless it is approving a plan.design/orchestration.md§7 names three agents.scc update.Plan
plans/plan-review-agent.md(approved, 5/5 tasks). The agent's own prompt reviewed that plan before approval: verdictrefine, catching the staledesign/orchestration.md§7 and a## Done whenwith no line for the skill dispatch — both applied.Verification
scc validate --checks --pr-> 12 validators, 0 findings;{"total": 1029, "coverage": 86.3}golangci-lint runclean;golangci-lint fmt --diffemptyReview
scc-code-review: clean — 5/5 tasks traced, scoped tests and lint green, 0 findings.scc-security-review: clean — no new path from input to effect, no privilege beyond the sibling reviewers. Two hypotheses noted, not acted on: prompt injection via plan/docs content (same exposure as the existing reviewers; only relevant if it is ever run on third-party plans unsandboxed), and read-only being prompt-enforced rather than tool-enforced (true of all three reviewers alike).