Repository navigation
fix(hooks): say unpushed work once at session start, not at the end of every turn - #61
Merged
Merged
Conversation
…f every turn On Stop, additionalContext continues the conversation, so the unpushed-work line read as an order and re-fired every turn spent waiting on reviews, on the user, or on a branch nobody wanted pushed yet. It also asked for a push ahead of the reviews delivery.md puts first. It now appears at SessionStart, beside drift, and points at the delivery sequence instead of a bare push. Plan: plans/undelivered-at-session-start.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The unpushed-work line moved from the Stop hook to SessionStart.
scc validatefindings.<branch>has N commits never pushed. When its work is done, deliver it per delivery.md: reviews, then push and the PR."Why: on Stop,
additionalContextkeeps the conversation going, so the old line read as an order. It re-fired at the end of every turn spent waiting on reviews, on the user, or on a branch nobody wanted pushed yet. It also asked for a push before the reviews that delivery.md requires first.Plan:
plans/undelivered-at-session-start.md. Docs updated:docs/wiki/pages/hooks.md, the README, the stage descriptions ininternal/hooks/harness.go, and the wiki changelog.Verification
scc validate --checks --prexit 0: 1037 tests, coverage 86.4%, 0 findings.TestUnpushedWorkIsReportedAtSessionStartOnly.TestStopIsSilentWhileTheHarnessIsAlreadyContinuingneeded something for Stop to report, and the unpushed line used to be it. Its fixture now uses a plan finding instead.golangci-lint runandfmt --diffare clean.Reviews
emitHookcomment is fixed. An overlong README line is left as is (cosmetic).