Cover the lasym cos part of the vacuum grpmn and bvec - #738
Merged
Conversation
jurasic-pf
requested changes
Sep 6, 2026
jurasic-pf
left a comment
Collaborator
There was a problem hiding this comment.
These comments are quire hard to read. The code should still be understandable and maintainable by humans, and not just ai.
CharlesCNorton
force-pushed
the
lasym-vacuum-tests
branch
from
September 6, 2026 21:25
92e70b6 to
4b9c2db
Compare
Contributor
Author
|
@jurasic-pf Rewriting them. Separately, #821 proposes fixing a layout for PR descriptions in AGENTS.md, for the same reason. |
Contributor
Author
|
@jurasic-pf Rather than reword the markers I removed the reason for them: educational_VMEC now writes the cos half (jonathanschilling/educational_VMEC#30), and the tests compare it on a new asymmetric free-boundary case at 1e-9. Retitled, since the PR no longer records a gap. |
CharlesCNorton
force-pushed
the
lasym-vacuum-tests
branch
3 times, most recently
from
September 7, 2026 14:13
5d7ac1b to
64579a6
Compare
jurasic-pf
approved these changes
Sep 7, 2026
jurasic-pf
left a comment
Collaborator
There was a problem hiding this comment.
Perfect! With test coverage and easy to read code
jurasic-pf
enabled auto-merge (squash)
September 7, 2026 23:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change - covers the cos halves of
grpmnandbvecin the NESTOR vacuum tests, on a new asymmetric free-boundary case, and drops the fourTODO(jons)markers that stood in for that coverage.Cause -
grpmnandbveccarry a second symmetry index forlasym, but educational_VMEC dumped only the first slice;analyt.f90notes it at the call as! missing dim: (ndim: 1 or 2). With no reference for the cos half, the asymmetric vacuum path was untested. jonathanschilling/educational_VMEC#30 writes it out.Evidence - the reference is a free-boundary
lasym = Tcth-like case at ns = 15, mpol = 5, ntor = 4, nfp = 5, generated with the mgrid VMEC++ already uses forcth_like_free_bdy_asym, md5-identical, and with every namelist parameter matchingcth_like_free_bdy_asym.json. Both halves agree at 1e-9, the same tolerance the symmetric case uses.Tests -
FourPTest,FourIAccumulateGrpmnTestandAnalytTestgaincth_like_free_bdy_asymat iteration 53 and comparegrpmn_cosandbvec_coswherelasymis set. Both C++ suites pass, 44/44.Scope - test-only. The symmetric cases are unchanged and the new comparisons are skipped when
lasymis false. Needs educational_VMEC#30 for anyone regenerating the reference; the JSONs are checked in, so the tests do not depend on it.