chore(deps-dev): bump the gemas-de-desarrollo group across 1 directory with 4 updates - #97
dependabot[bot] wants to merge 3 commits into
Conversation
…y with 4 updates Bumps the gemas-de-desarrollo group with 4 updates in the / directory: [rubocop](https://github.com/rubocop/rubocop), [rubocop-rails](https://github.com/rubocop/rubocop-rails), [lefthook](https://github.com/evilmartians/lefthook) and [simplecov](https://github.com/simplecov-ruby/simplecov). Updates `rubocop` from 1.90.0 to 1.91.0 - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.90.0...v1.91.0) Updates `rubocop-rails` from 2.37.0 to 2.38.0 - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rails@v2.37.0...v2.38.0) Updates `lefthook` from 2.1.12 to 2.1.14 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.1.12...v2.1.14) Updates `simplecov` from 1.3.0 to 1.3.1 - [Release notes](https://github.com/simplecov-ruby/simplecov/releases) - [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md) - [Commits](simplecov-ruby/simplecov@v1.3.0...v1.3.1) --- updated-dependencies: - dependency-name: lefthook dependency-version: 2.1.14 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: gemas-de-desarrollo - dependency-name: rubocop dependency-version: 1.91.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: gemas-de-desarrollo - dependency-name: rubocop-rails dependency-version: 2.38.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: gemas-de-desarrollo - dependency-name: simplecov dependency-version: 1.3.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: gemas-de-desarrollo ... Signed-off-by: dependabot[bot] <support@github.com>
8df4176 to
71d3423
Compare
Sanntinat
left a comment
There was a problem hiding this comment.
Revisión — Dependabot (PR #97) · Gemas de desarrollo: RuboCop 1.91, rubocop-rails 2.38, lefthook, simplecov
Revisión de dependabot/bundler/gemas-de-desarrollo-8960840dd6, contra origin/master de proyecto-api.
| Check | Resultado |
|---|---|
| CI (GitHub Actions) | test en rojo: 1567 ejemplos, 1449 fallas |
Rama vs master |
12 commits atrás. Mergea limpio |
| Reproducido en local | Sí: el mismo ArgumentError en los specs de modelos |
🔴 El grupo «de desarrollo» sube una gem de runtime de versión mayor
Además de las cuatro gems del grupo, el lock trae json 2.21.2 → 3.0.2, que entra de arrastre (RuboCop pide json >= 2.3 y Dependabot resolvió a la última). json no es de desarrollo: la usa Rails en runtime, también en producción.
Con Rails 8.1.3.1, que es el de master, json 3 rompe la serialización:
ArgumentError:
wrong number of arguments (given 2, expected 1)
# ./spec/avo/filters_spec.rb:16 Company.create!(...)
Se cae todo lo que guarda o serializa JSON (columnas jsonb, serializers, mappers): 1449 de 1567 ejemplos.
Cómo sale
Rails 8.1.4 soporta json 3, y lo trae #96 (el grupo de producción). Lo probé de dos maneras:
- #96 primero y después estas cuatro gems encima (lo que va a hacer Dependabot al rebasear): 1744 ejemplos, 0 fallas, y RuboCop 1.91 / rubocop-rails 2.38 sin ninguna ofensa nueva en los 314 archivos.
- Sólo las cuatro gems sobre
master, sin tocarjson(bundle lock --update rubocop rubocop-rails lefthook simplecov --conservative):jsonqueda en 2.21.2, y también da 1744 ejemplos en verde.
Lo más simple es mergear #96 y pedirle a Dependabot que rebasee este PR. Si por algún motivo #96 se demora, la segunda opción sirve igual.
⚪ Para la configuración de Dependabot
Vale la pena que un grupo «de desarrollo» no pueda subir de versión mayor una dependencia de runtime. Una regla ignore para json con update-types: ["version-update:semver-major"] en el grupo de desarrollo lo evita. El grupo de producción la va a seguir subiendo junto con Rails, que es donde corresponde.
Veredicto
REQUEST CHANGES (para que no se mergee así): con el lock actual se cae la suite. Después de #96 y del rebase, apruebo.
The group bump carried `json` from 2.21.2 to 3.0.2 and the suite went red in places that have nothing to do with the gems being updated: the Avo filters, the adapter errors, the shipment errors. All of them with the same `ArgumentError: wrong number of arguments (given 2, expected 1)`. It is not our code. `json` 3.0 dropped the two-positional form `JSON.parse(source, options_hash)`, and `ActiveSupport::JSON.decode` still calls it that way (activesupport 8.1.3.1, `active_support/json/decoding.rb:25`). With 3.x installed, reading any `json` or `jsonb` column raises: webhook payloads, integration credentials, the template mappers, the Avo panel. `json` is not in the Gemfile -- it arrives through rubocop -- so the constraint goes in explicitly, with the reason, to stop Dependabot from raising it again on its own. The other four updates in this group land as they came. 1567 examples, 0 failures. RuboCop clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012xAtddb53LRNVLuyTXyELp
The production group (#96) landed first and both PRs write Gemfile.lock, so this one went into conflict. The lock is rebuilt from master's and the four dev updates re-applied on top, which also picks up what moved since the bump was opened: parallel 2.3.0, simplecov 1.3.2 and lefthook 2.1.17. `json` stays on 2.21.2 for the reason in the Gemfile: ActiveSupport 8.1 calls `JSON.parse` with two positionals and 3.x dropped that form. 1753 examples, 0 failures. RuboCop clean on 314 files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012xAtddb53LRNVLuyTXyELp
Bumps the gemas-de-desarrollo group with 4 updates in the / directory: rubocop, rubocop-rails, lefthook and simplecov.
Updates
rubocopfrom 1.90.0 to 1.91.0Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
6eee0afCut 1.91ed0572dUpdate Changelog3181272Fix an infinite loop forStyle/NumericLiteralPrefixwith signed literalsb87652aFix Layout/LineLength SplitStrings loop on trailing-space split pointfce7a33[Fix #15638] Fix first array indentation loop321bd65#15347 Fix an incorrect autocorrect forStyle/NestedModifiera464cba#15347 Fix incorrect autocorrects forStyle/NilComparisonwith precedence...3192b70#15347 Fix an incorrect autocorrect forStyle/NonNilCheckf747cab#15347 Fix an incorrect autocorrect forStyle/Notwith a flip-flop or ass...3f52020Add CHANGELOG entry for the preview fail levelUpdates
rubocop-railsfrom 2.37.0 to 2.38.0Release notes
Sourced from rubocop-rails's releases.
Changelog
Sourced from rubocop-rails's changelog.
Commits
9b25387Cut 2.38.03bf4e62Update Changeloge3df883Merge pull request #1662 from viralpraxis/fix-an-error-for-rails-read-write-a...74464cdFix an error forRails/ReadWriteAttributecop38949cdMerge pull request #1660 from viralpraxis/fix-an-incorrect-autocorrect-for-ra...f504da1Fix an incorrect autocorrect forRails/RakeEnvironmentcop5e2998eMerge pull request #1657 from koic/fix_version_gated_cops_to_respect_target_r...72dfac3Fix version-gated cops to respectAllCops: TargetRailsVersiona4655cbMerge pull request #1655 from koic/extract_target_rails_version_resolutionfd01923ResolveTargetRailsVersionwithin RuboCop Rails itselfUpdates
lefthookfrom 2.1.12 to 2.1.14Release notes
Sourced from lefthook's releases.
Changelog
Sourced from lefthook's changelog.
Commits
1e235532.1.14: small fixes and spinner improvementsa2c9d372.1.13: small fixes and spinner improvementsc7b4983fix(run): error when --job/--command matches nothing (#1512)e4ca4a1fix: disable tty things when stdout is not TTY (#1545)aa3fa89docs: document files inheritance for grouped jobs (#1536)250f028fix: force colors when colors are explicitly enabled (#1538)62f4d5efix: resolve file_types paths from the repo root (#1537)ef092ebfix(npm) don't force pastcore.hooksPathguard in npm postinstall (#1475)3667aebfix: don't force-install hooks from the npm postinstall (#1510)354df23docs: quote template run examples (#1472)Updates
simplecovfrom 1.3.0 to 1.3.1Release notes
Sourced from simplecov's releases.
Changelog
Sourced from simplecov's changelog.
Commits
4ee7894Bump version to 1.3.1486e55ebundle updated2a62a8Resolve paths and wait on runners correctly on JRuby on Windows3a2e08eLoad Prism only when the static extractor runs08006c4Look up Action View handlers on the new registry0e0b168Bump oxlint from 1.82.0 to 1.83.0 in /html_frontendc1641b7Bump@happy-dom/global-registratorin /html_frontend26920afBump ruby/setup-ruby from 1.321.0 to 1.323.0b18f50dBump oxlint from 1.81.0 to 1.82.0 in /html_frontenda7fa17eBump@types/bunfrom 1.4.1 to 1.4.2 in /html_frontend