Skip to content

Fix source intensity normalization #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psheehan merged 1 commit into from
Jul 14, 2026
Merged

Fix source intensity normalization #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pinballrt/sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def emit_rays(self, nu, distance_unit, ez, nrays, physical_pixel_size, device="c

direction = torch.unsqueeze(torch.tensor(ez, dtype=torch.float32, device=device), 0).repeat(nrays, 1)

intensity = (self.intensity(nu.data)*np.pi).to(u.Jy / u.steradian).value * \
intensity = (self.intensity(nu.data)*np.pi / nrays).to(u.Jy / u.steradian).value * \
((self.radius / physical_pixel_size).decompose()**2).value
intensity = torch.unsqueeze(torch.tensor(intensity, dtype=torch.float32, device=device), 0).repeat(nrays, 1)
tau_intensity = torch.zeros((nrays, nu.size), dtype=torch.float32, device=device)
Expand Down
1 change: 1 addition & 0 deletions pinballrt/tests/test_E2E.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ def test_E2E(grid_class, grid_kwargs, dust, percentile, device, return_vals=Fals
base_image = xr.open_dataset(os.path.join(os.path.dirname(__file__), f"data/{grid_class.__name__}_E2E_image.nc"))
Q = calculate_Qvalue(image.intensity.data.value, base_image.intensity, percentile=99.0, clip=0.1)
assert Q < 1.025, f"Image difference exceeds tolerance: {Q}"
assert np.abs(image.intensity.data.value.max() - base_image.intensity.max()) < 0.01 * base_image.intensity.max(), f"Image max difference exceeds tolerance: {(image.intensity.max() - base_image.intensity.max()) / base_image.intensity.max()}"

base_mom0 = xr.open_dataset(os.path.join(os.path.dirname(__file__), f"data/{grid_class.__name__}_E2E_mom0.nc"))
Q = calculate_Qvalue(mom0.intensity.data.value, base_mom0.intensity, percentile=99.0, clip=0.1)
Expand Down
Loading