Skip to content

Patch/UI test dom assertions - #210

Merged
psilabs-dev merged 7 commits into
mainfrom
patch/ui-test-dom-assertions
Sep 8, 2026
Merged

psilabs-dev merged 7 commits into
mainfrom
patch/ui-test-dom-assertions

Conversation

@psilabs-dev

@psilabs-dev psilabs-dev commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Apply these fixes with playwright tests.

  1. in a normal stable page, there shouldn't be a spinner anywhere.
  2. in a normal UI page, there should be no error toasts.
  3. any playwright test needs user actions instead of API calls when testing any UI scope of interest (automation is exempt unless what's being automated is the thing being tested, in which case -> run test with user actions).

DX improvement: PlaywrightTestContextManager to manage every single playwright context. Without it, logic errors and scope coverage leaks are happening all over the place, it's getting kind of ridiculous also how often duplication is happening.

@psilabs-dev psilabs-dev self-assigned this Sep 8, 2026
@psilabs-dev
psilabs-dev force-pushed the patch/ui-test-dom-assertions branch from 831cfda to 597e7e3 Compare September 8, 2026 02:53
@psilabs-dev
psilabs-dev merged commit 8f2fba6 into main Sep 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant