fix: ORDER BY id in _get_scalar_relation_map#24
Open
rafabench wants to merge 1 commit into
Open
Conversation
Without ORDER BY, SQLite was free to pick an index-driven scan when a covering index existed on the FK column, traversing rows in FK-value order and producing a shuffled relation vector. Every other read in this file already orders by id; this one was the outlier. Closes #23 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Is this for which model? @rafabench |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORDER BY idto the SELECT in_get_scalar_relation_map(src/read.jl:594).Without
ORDER BY, SQLite is free to use a covering index for the scan and traverses rows in FK-value order — so the returned relation vector ends up shuffled relative to source-id order. Every other read in this file already orders explicitly; this one was the outlier.Test plan
Pkg.test()for PSRDatabase.jl — all existing tests passgot == expected)