Repository navigation
Conversation
This implements remote port detection for services running in uncloud, when you proxy to them you only need to give the service name and proxy will figure it out. This does not cross reference with x-ports, nor does check the expose syntax (for the love of it, I couldn't find where to add that). This also means adding/remove expose ports isn't detected as a service change. Having said that, it works beautifully: ``` % ./uc proxy debug http://127.0.0.1:44345 → 10.210.0.19:80 (debug/f33620ea40f3) % ./uc proxy debug 12334: http://127.0.0.1:12334 → 10.210.0.19:80 (debug/f33620ea40f3) % ./uc proxy debug 80 http://127.0.0.1:39815 → 10.210.0.19:80 (debug/f33620ea40f3) % ./uc proxy perses http://127.0.0.1:42617 → 10.210.0.9:8080 (perses/6e51faac2888) % ./uc proxy prometheus http://127.0.0.1:44803 → 10.210.0.8:9090 (prometheus/709cf40d7305) % ./uc proxy uniprune Error: no remote port specified and no exposed ports found for service 'uniprune' services: debug: image: code.atoom.net/miek/base/debug:latest expose: - 25 - 80 [1] % ./uc proxy debug ┃ Select a port ┃ > 25 ┃ 80 ↑ up • ↓ down • / filter • enter submit ``` Fixes: psviderski#453 Signed-off-by: Miek Gieben <miek@miek.nl>
Contributor
Author
I tend to get lost in the service vs servce container stuff - adding it in the place I though it would do something didn't matter; maybe you can easily fix that though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements remote port detection for services running in uncloud, when you proxy to them you only need to give the service name and proxy will figure it out.
This does not cross reference with x-ports, nor does check the expose syntax (for the love of it, I couldn't find where to add that). This also means adding/remove expose ports isn't detected as a service change.
Having said that, it works beautifully:
Fixes: #453