Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the permutation testing infrastructure to support pattern-based replication, addressing issue #3. The changes migrate from using tarchetypes::tar_rep_raw() to a custom pattern-based approach for better integration with the targets workflow.
- Adds pattern support to
tar_cluster_permutation()andtar_mantel()functions - Replaces batch-based permutation with a custom
run_rep_df()function that generates replications as list columns - Updates target calls to use the new pattern-based approach with increased default replications (1000 vs previous 10)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| _targets.R | Adds pattern and iteration parameters to specific targets using the new replication system |
| R/tar_factories.R | Major refactor of permutation functions to support pattern-based replication with new run_rep_df() helper |
| R/clusters.R | Updates default column identifier for permuted data from starts_with("tar") to .rep |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
Author
|
In fact, I must use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used to fix #3.